修复AvatarPreview在脚本编译或者Play的时候会导致的内存泄漏问题

Author: XINCGer

Assets/Editor/Examples/Constants.cs

@@ -10,5 +10,6 @@ public class Constants
         public const string GLOBAL_INPUT_ENEVT_ENABLE = "__GLOBAL_INPUT_ENEVT_ENABLE__";
 
         public static readonly GUIStyle preBackgroundSolid = "PreBackgroundSolid";
+        public const string PREVIRE_TAG = "PREVIRE_TAG";
     }
 }

Assets/Editor/Examples/Example_09_AvatarPreview/AvatarPreview.cs

@@ -269,6 +269,7 @@ static GameObject CalculatePreviewGameObject(Animator selectedAnimator, Motion m
 
             // Use selected preview
             GameObject selected = EditorHelper.InstantiateGoByPrefab(selectedAnimator.gameObject, null);
+            selected.tag = Constants.PREVIRE_TAG;
             InitInstantiatedPreviewRecursive(selected);
             if (IsValidPreviewGameObject(selected, ModelImporterAnimationType.None))
                 return selected;
@@ -315,6 +316,7 @@ void SetupBounds(GameObject go)
             if (go != null)
             {
                 m_PreviewInstance = ReflectionHelper.Instance.EditorUtility.InstantiateForAnimatorPreview(go);
+                m_PreviewInstance.tag = Constants.PREVIRE_TAG;
                 previewUtility.AddSingleGO(m_PreviewInstance);
 
                 Bounds bounds = new Bounds(m_PreviewInstance.transform.position, Vector3.zero);
@@ -351,6 +353,7 @@ void InitInstance(Animator scenePreviewObject, Motion motion)
             {
                 GameObject referenceGO = (GameObject) EditorGUIUtility.Load("Avatar/dial_flat.prefab");
                 m_ReferenceInstance = (GameObject) Object.Instantiate(referenceGO, Vector3.zero, Quaternion.identity);
+                m_ReferenceInstance.tag = Constants.PREVIRE_TAG;
                 InitInstantiatedPreviewRecursive(m_ReferenceInstance);
                 previewUtility.AddSingleGO(m_ReferenceInstance);
             }
@@ -359,6 +362,7 @@ void InitInstance(Animator scenePreviewObject, Motion motion)
             {
                 GameObject directionGO = (GameObject) EditorGUIUtility.Load("Avatar/arrow.fbx");
                 m_DirectionInstance = (GameObject) Object.Instantiate(directionGO, Vector3.zero, Quaternion.identity);
+                m_DirectionInstance.tag = Constants.PREVIRE_TAG;
                 InitInstantiatedPreviewRecursive(m_DirectionInstance);
                 previewUtility.AddSingleGO(m_DirectionInstance);
             }
@@ -367,6 +371,7 @@ void InitInstance(Animator scenePreviewObject, Motion motion)
             {
                 GameObject pivotGO = (GameObject) EditorGUIUtility.Load("Avatar/root.fbx");
                 m_PivotInstance = (GameObject) Object.Instantiate(pivotGO, Vector3.zero, Quaternion.identity);
+                m_PivotInstance.tag = Constants.PREVIRE_TAG;
                 InitInstantiatedPreviewRecursive(m_PivotInstance);
                 previewUtility.AddSingleGO(m_PivotInstance);
             }
@@ -375,6 +380,7 @@ void InitInstance(Animator scenePreviewObject, Motion motion)
             {
                 GameObject rootGO = (GameObject) EditorGUIUtility.Load("Avatar/root.fbx");
                 m_RootInstance = (GameObject) Object.Instantiate(rootGO, Vector3.zero, Quaternion.identity);
+                m_RootInstance.tag = Constants.PREVIRE_TAG;
                 InitInstantiatedPreviewRecursive(m_RootInstance);
                 previewUtility.AddSingleGO(m_RootInstance);
             }
@@ -456,14 +462,7 @@ private void Init()
 
         public void OnDisable()
         {
-            if (m_PreviewUtility != null)
-            {
-                m_PreviewUtility.Cleanup();
-                m_PreviewUtility = null;
-            }
-
-            if (timeControl != null)
-                timeControl.OnDisable();
+            OnDestroy();
         }
 
         public void OnDestroy()
@@ -1160,5 +1159,16 @@ internal static void SetEnabledRecursive(GameObject go, bool enabled)
                 renderer.enabled = enabled;
             }
         }
+
+        [UnityEditor.Callbacks.DidReloadScripts]
+        private static void OnScriptsReloaded()
+        {
+            var gameobjects = GameObject.FindGameObjectsWithTag(Constants.PREVIRE_TAG);
+            foreach (var item in gameobjects)
+            {
+                GameObject.DestroyImmediate(item);
+            }
+            
+        }
     }
 }

Assets/Editor/Examples/Example_09_AvatarPreview/PreviewWindow.cs

@@ -47,6 +47,7 @@ private void OnGUI()
                 var prefab = AssetDatabase.LoadAssetAtPath<GameObject>(AVATAR_PATH);
                 PreviewInstance = EditorHelper.InstantiateGoByPrefab(prefab, null);
                 PreviewInstance.hideFlags = HideFlags.HideAndDontSave;
+                PreviewInstance.tag = Constants.PREVIRE_TAG;
                 _previewAnimator = AssetDatabase.LoadAssetAtPath<AnimatorController>(PREVIEW_ANIMCONTROLLER_PATH);
                 _animationClip = AssetDatabase.LoadAssetAtPath<AnimationClip>(CLIP_PATH);
                 var states = _previewAnimator.layers[0].stateMachine.states;
@@ -125,5 +126,13 @@ private void OnDestroy()
             _previewAnimator = null;
             _animatorState = null;
         }
+
+        private void OnDisable()
+        {
+            if (null != _avatarPreview)
+            {
+                _avatarPreview.OnDisable();
+            }
+        }
     }
 }

ProjectSettings/TagManager.asset

@@ -3,7 +3,8 @@
 --- !u!78 &1
 TagManager:
   serializedVersion: 2
-  tags: []
+  tags:
+  - PREVIRE_TAG
   layers:
   - Default
   - TransparentFX