shm: use embedded private instead of pointer #1124
Conversation
metux
requested review from
ONykyf,
algrid,
b-aaz,
callmetango,
cepelinas9000,
jonhermansen,
josephcrowell,
mikedld and
stefan11111
The private struct is pretty small and it needs to be allocated anyways, so save an extra allocation by directly embedding it. Signed-off-by: Enrico Weigelt, metux IT consult <[email protected]>
|
|
||
|
|
||
| typedef struct _ShmScrPrivateRec { | ||
| Bool initialized; |
There was a problem hiding this comment.
Do we need this flag at all? It looks like it’s set, but not really used. Or it’s intended for external usage?
There was a problem hiding this comment.
it's supposed to protect from duplicate initialization.
the original code was looking at the pointer value, so I kept this flag for safety.
not sure whether it's really needed.
There was a problem hiding this comment.
Maybe print some warning (or a fatal error?) if a repeated init or deinit is attempted? To add some meaning to that flag 🙂
|
Merge Conflict found |
stefan11111
left a comment
stefan11111
left a comment
There was a problem hiding this comment.
Other than what @algrid said, lgtm
|
Merge Conflict found |
6 similar comments
|
Merge Conflict found |
|
Merge Conflict found |
|
Merge Conflict found |
|
Merge Conflict found |
|
Merge Conflict found |
|
Merge Conflict found |
|
Merge Conflict found |
|
This has become obsoleted by #1236 |
metux
deleted the
pr/shm-use-embedded-private-instead-of-pointer-_2025-09-23_17-01-11
branch
The private struct is pretty small and it needs to be allocated anyways,
so save an extra allocation by directly embedding it.
Signed-off-by: Enrico Weigelt, metux IT consult [email protected]