Skip to content

Commit f609b18

Browse files
committed
render: XineramaRenderSetPictureClipRectangle(): don't patch request buffer anymore
No need for patching up the request buffer anymore - just pass in the correct value directly. Signed-off-by: Enrico Weigelt, metux IT consult <[email protected]>
1 parent 99590ab commit f609b18

File tree

1 file changed

+10
-9
lines changed

1 file changed

+10
-9
lines changed

render/render.c

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -551,12 +551,13 @@ SingleRenderChangePicture(ClientPtr client, xRenderChangePictureReq *stuff, Pict
551551

552552
static int
553553
SingleRenderSetPictureClipRectangles(ClientPtr client,
554-
xRenderSetPictureClipRectanglesReq *stuff)
554+
xRenderSetPictureClipRectanglesReq *stuff,
555+
Picture pictID)
555556
{
556557
PicturePtr pPicture;
557558
int nr;
558559

559-
VERIFY_PICTURE(pPicture, stuff->picture, client, DixSetAttrAccess);
560+
VERIFY_PICTURE(pPicture, pictID, client, DixSetAttrAccess);
560561
if (!pPicture->pDrawable)
561562
return RenderErrBase + BadPicture;
562563

@@ -2018,16 +2019,16 @@ PanoramiXRenderChangePicture(ClientPtr client, xRenderChangePictureReq *stuff, P
20182019

20192020
static int
20202021
PanoramiXRenderSetPictureClipRectangles(ClientPtr client,
2021-
xRenderSetPictureClipRectanglesReq *stuff)
2022+
xRenderSetPictureClipRectanglesReq *stuff,
2023+
Picture pictID)
20222024
{
20232025
int result = Success;
20242026
PanoramiXRes *pict;
20252027

2026-
VERIFY_XIN_PICTURE(pict, stuff->picture, client, DixWriteAccess);
2028+
VERIFY_XIN_PICTURE(pict, pictID, client, DixWriteAccess);
20272029

20282030
XINERAMA_FOR_EACH_SCREEN_BACKWARD({
2029-
stuff->picture = pict->info[walkScreenIdx].id;
2030-
result = SingleRenderSetPictureClipRectangles(client, stuff);
2031+
result = SingleRenderSetPictureClipRectangles(client, stuff, pict->info[walkScreenIdx].id);
20312032
if (result != Success)
20322033
break;
20332034
});
@@ -2655,10 +2656,10 @@ ProcRenderSetPictureClipRectangles(ClientPtr client)
26552656
}
26562657

26572658
#ifdef XINERAMA
2658-
return (usePanoramiX ? PanoramiXRenderSetPictureClipRectangles(client, stuff)
2659-
: SingleRenderSetPictureClipRectangles(client, stuff));
2659+
return (usePanoramiX ? PanoramiXRenderSetPictureClipRectangles(client, stuff, stuff->picture)
2660+
: SingleRenderSetPictureClipRectangles(client, stuff, stuff->picture));
26602661
#else
2661-
return SingleRenderSetPictureClipRectangles(client, stuff);
2662+
return SingleRenderSetPictureClipRectangles(client, stuff, stuff->picture);
26622663
#endif
26632664
}
26642665

0 commit comments

Comments
 (0)