Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instructions for Gradle 6.2+ doesn't work with ForgeGradle #28

Open
AterAnimAvis opened this issue Mar 4, 2024 · 3 comments
Open

Instructions for Gradle 6.2+ doesn't work with ForgeGradle #28

AterAnimAvis opened this issue Mar 4, 2024 · 3 comments

Comments

@AterAnimAvis
Copy link

The instructions for Gradle 6.2+ suggests using an exclusiveContent block, this however won't work with ForgeGradle as it prevents the DeobfuscatingRepo from providing the deobfuscated artifacts (which have the same group as the original).

@Wyn-Price
Copy link
Owner

Sorry for the delayed reply. Is there anything I should change it to? Or just put a note that it won't work for ForgeGradle?

@AterAnimAvis
Copy link
Author

AterAnimAvis commented Apr 9, 2024

Just a note that it won't work for ForgeGradle (3-6, FG2 and below iirc change the group) and NeoGradle 6. NeoGradle 7 will work just fine with it since we no longer do obf/deobf.

fg.deobf transforms the dependency GAV from {group}:{artifact}:{version} to {group}:{artifact}:{version}_mapped_{mappings-channel}_{mappings-version}, the DeobfuscatingRepo then provides those dependencies dynamically, remapping the originals.
The exclusiveContent block filter on the group that is currently recommended prevents that from happening, as anything under that group only checks the CurseMaven repo, preventing the DeobfuscatingRepo from providing those mapped dependencies.

@Matyrobbrt
Copy link

Alternatively, in FG/NG6 you can keep using the exclusiveContent, assuming you also declare a forRepositories fg.deobfuscatingRepo:

repositories {
    exclusiveContent {
        forRepository {
            maven {
                url "https://cursemaven.com"
            }
        }
        forRepositories fg.deobfuscatingRepo
        filter {
            includeGroup "curse.maven"
        }
    }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants