Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOT_READABLE properties are not properly audited #64

Open
pavelhoral opened this issue Aug 28, 2018 · 0 comments
Open

NOT_READABLE properties are not properly audited #64

pavelhoral opened this issue Aug 28, 2018 · 0 comments

Comments

@pavelhoral
Copy link
Member

Right now the activity audit works based on object before a and object after states. That means if there are attributes marked as NOT_READABLE, those will never get included in the audit record. Fields marked as not readable might be important fields like userPassword, which means that passwordchanged audit flag won't be filled.

Relevant references:

Suggested fix:

Change detection should take fields from the request into account (i.e. sending update/patch/create request field names to audit service together with before and after object state).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant