Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Waypoint data for various Winter Veil gift rewards appears to be outdated and/or inconsistent (?) #695

Open
rdw-software opened this issue Dec 23, 2023 · 0 comments

Comments

@rdw-software
Copy link
Member

rdw-software commented Dec 23, 2023

Don't have time to fix them right now and it's probably not very important, but still...

It looks as though many of the toys that are now available from Stolen Present have waypoint data that doesn't reflect this fact.

Example:

	["Zhevra Lounge Cushion"] = {
		cat = CONSTANTS.ITEM_CATEGORIES.HOLIDAY,
		type = CONSTANTS.ITEM_TYPES.ITEM,
		isToy = true,
		method = CONSTANTS.DETECTION_METHODS.USE,
		name = L["Zhevra Lounge Cushion"],
		itemId = 116691,
		items = { 21271, 21270, 116762 },
		chance = 4,
		sourceText = L["Available starting December 25th"],
		holidayTexture = CONSTANTS.HOLIDAY_TEXTURES.WINTERS_VEIL,
		questId = { 8788, 8767 },
		coords = { { m = 86, x = 49.1, y = 78.2, h = true }, { m = 87, x = 33.4, y = 65.9, a = true } },
	},

This part is placing the waypoints in Orgrimmar and Stormwind, respectively (where the Winter Veil gifts are located):

coords = { { m = 86, x = 49.1, y = 78.2, h = true }, { m = 87, x = 33.4, y = 65.9, a = true } },

Now, the question is... was this intentional? Should they have waypoints for both the Stolen Present and this, or just Hillsbrad?

There's currently 22 items using the Abominable Snowman turnin location, which seems correct to me:

coords = { { m = CONSTANTS.UIMAPIDS.HILLSBRAD_FOOTHILLS, x = 43.6, y = 39.6 } },

By contrast, only four items are using Orgrimmar/Stormwind and then a few pets with christmasOnly and zoneOverride flags... 🤔

Overall those entries are fairly inconsistent, so not sure if they could all be streamlined?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant