Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write patch extraction metadata directly to STAC API #228

Merged
merged 7 commits into from
Nov 29, 2024

Conversation

VincentVerelst
Copy link
Contributor

@VincentVerelst VincentVerelst commented Nov 25, 2024

  • Recommended to add two new environment variables STAC_API_USERNAME and STAC_API_PASSWORD. If these don't exist, authentication will happen via authentication code flow, which will require manual intervention for each batch job, which is not very practical
  • Currently URLs point to openeo-dev STAC API, untill we get the correct permissions for POST requests to the prod STAC API (WIP by DevOps)
  • Two collections have been created: worldcereal_sentinelx_patch_extractions. We're in talks with the DevOps team to only give PUT, POST and DELETE permissions to the 'wcextractions' account, so that other users cannot accidentally overwrite the STAC metadata. To be seen if this is possible
  • One blocking point on the prod STAC API is the non-working /bulk_items/ endpoint. DevOps team is aware.

@VincentVerelst
Copy link
Contributor Author

@kvantricht , @cbutsko, not ready to be merged until issues above are finished, but the code is ready for review.

Copy link
Contributor

@kvantricht kvantricht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks cool! Not easy for me to understand what happens just from code. Do we need tests for this functionality? Once this thing is kind of operational, we should sit together to have a strategy for ingesting previous extractions as well.

src/worldcereal/openeo/extract.py Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@VincentVerelst VincentVerelst marked this pull request as ready for review November 29, 2024 11:11
Copy link
Contributor

@kvantricht kvantricht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very clean code!! I'll approve and let's see how it goes in practice.

@VincentVerelst VincentVerelst merged commit 3cf8a38 into main Nov 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants