Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional argument 'settings' in worldcereal_preprocessed_inputs #87

Open
VincentVerelst opened this issue Jun 27, 2024 · 3 comments
Open
Assignees

Comments

@VincentVerelst
Copy link
Contributor

would be nice to have an additional optional argument "settings" for the worldcereal_preprocessed_inputs_gfmap function, specifying:

  • which bands to extract for each collection
  • compositing method to use (for now only median compositing supported, but we would like to test BAP compositing as well in the near future)
    the compositing window ('month', 'dekad')
    Or perhaps a better approach would be to extend the collections argument allowing to pass additional settings per collection
@kvantricht
Copy link
Contributor

@GriffinBabe for now I assigned this to you but this may need to change. If you can give this a thought that would be great.

@GriffinBabe
Copy link
Contributor

I would extend the logic of the parameters we created for the CropLand workflow

https://github.com/WorldCereal/worldcereal-classification/blob/main/src/worldcereal/job.py#L59

Here we have classes CropLandParameters and CropTypeParameters, we could define an additional class WorldCerealInputParameters or similar that will also use pydantic for type consistency/checking

Then all the parameter objects that use inputs (CropLandParameters, CropTypeParameters) would have a field instance of that class.

@kvantricht kvantricht changed the title Additional argument 'settings' in worldcereal_preprocessed_inputs_gfmap Additional argument 'settings' in worldcereal_preprocessed_inputs Oct 30, 2024
@jdegerickx
Copy link
Contributor

@kvantricht , you think this is still needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants