Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicated band name remapping procedures in worldcereal-classification and in presto-worldcereal #55

Closed
kvantricht opened this issue Jun 12, 2024 · 0 comments
Closed

Duplicated band name remapping procedures in worldcereal-classification and in presto-worldcereal #55

kvantricht opened this issue Jun 12, 2024 · 0 comments
Labels
enhancement New feature or request
Milestone
System V1

Comments

@kvantricht
Copy link
Contributor 

          This is in fact a bit an overhead, if later on in `presto-worldcereal` we again remap: https://github.com/WorldCereal/presto-worldcereal/blob/main/presto/inference.py#L41

So we should consider to immediately use the presto naming here and remove the remapping in presto-worldcereal

Originally posted by @kvantricht in #48 (comment)
@kvantricht kvantricht changed the title Duplicated band name remapping procedures here and in presto-worldcereal Duplicated band name remapping procedures in worldcereal-classification and in presto-worldcereal Jun 12, 2024
@kvantricht kvantricht added the enhancement New feature or request label Jun 19, 2024
@kvantricht kvantricht added this to the System V1 milestone Jun 27, 2024
@kvantricht kvantricht mentioned this issue Aug 23, 2024
Merged
kvantricht added a commit that referenced this issue Aug 23, 2024
@kvantricht
#55 Immediately map to presto band names
1a7d6a2
@kvantricht kvantricht mentioned this issue Aug 23, 2024
Merged
GriffinBabe added a commit that referenced this issue Aug 23, 2024
@GriffinBabe
Merge pull request #131 from WorldCereal/55-duplicate-bandremapping
ea6b829 
#55 Immediately map to presto band names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
System V1
Development

No branches or pull requests
1 participant
@kvantricht