Fix shift click on X of tooltip not working to disable the tooltip

WorldBrain · Jul 24, 2024 · 9630e11 · 9630e11
1 parent 9b9e8b6
commit 9630e11
Show file tree

Hide file tree

Showing 6 changed files with 16 additions and 1 deletion.
diff --git a/external/@worldbrain/memex-common b/external/@worldbrain/memex-common
diff --git a/src/content-scripts/content_script/global.ts b/src/content-scripts/content_script/global.ts
@@ -1202,6 +1202,9 @@ export async function main(
                 pageActivityIndicatorBG,
                 localStorageAPI: browser.storage.local,
                 syncSettingsBG: syncSettingsBG,
+                toggleTooltipState: async (state: boolean) => {
+                    tooltipUtils.setTooltipState(state)
+                },
             })
             components.tooltip?.resolve()
         },
@@ -1315,6 +1318,9 @@ export async function main(
         updateRibbon: async () => inPageUI.updateRibbon(),
         showContentTooltip: async () => inPageUI.showTooltip(),
         insertTooltip: async () => inPageUI.showTooltip(),
+        toggleTooltipState: async (state: boolean) => {
+            this.dependencies.tooltip.setState(state)
+        },
         removeTooltip: async () => inPageUI.removeTooltip(),
         insertOrRemoveTooltip: async () => inPageUI.toggleTooltip(),
         goToHighlight: async (annotationCacheId) => {

diff --git a/src/in-page-ui/content_script/types.ts b/src/in-page-ui/content_script/types.ts
@@ -24,6 +24,7 @@ export interface InPageUIContentScriptRemoteInterface {
     // Tooltip
     showContentTooltip(): Promise<void>
     insertTooltip(): Promise<void>
+    toggleTooltipState(state: boolean): Promise<void>
     removeTooltip(): Promise<void>
     insertOrRemoveTooltip(): Promise<void>
 

diff --git a/src/in-page-ui/tooltip/content_script/components/index.tsx b/src/in-page-ui/tooltip/content_script/components/index.tsx
@@ -50,6 +50,7 @@ interface TooltipRootProps {
     mount: InPageUIRootMount
     params: Omit<Props, 'onTooltipInit'>
     onTooltipInit: (showTooltip: () => void) => void
+    toggleTooltipState: (state: boolean) => Promise<void>
     analyticsBG: AnalyticsCoreInterface
     annotationsBG: AnnotationInterface<'caller'>
     annotationsCache: PageAnnotationsCache
@@ -531,6 +532,7 @@ class TooltipRoot extends React.Component<TooltipRootProps, TooltipRootState> {
                             this.renderHighlightColorPicker
                         }
                         showColorPicker={this.state.showColorPicker}
+                        toggleTooltipState={props.toggleTooltipState}
                     />
                 </ThemeProvider>
             </StyleSheetManager>
@@ -563,6 +565,7 @@ export function setupUIContainer(
                 syncSettingsBG={props.syncSettingsBG}
                 createHighlight={params.createHighlight}
                 getWindow={params.getWindow}
+                toggleTooltipState={props.toggleTooltipState}
             />,
             mount.rootElement,
         )

diff --git a/src/in-page-ui/tooltip/content_script/interactions.ts b/src/in-page-ui/tooltip/content_script/interactions.ts
@@ -105,6 +105,9 @@ export const insertTooltip = async (params: TooltipInsertDependencies) => {
             },
             onTooltipHide: () => params.inPageUI.hideTooltip(),
             onTooltipClose: () => params.inPageUI.removeTooltip(),
+            toggleTooltipState: async (state: boolean) => {
+                params.toggleTooltipState
+            },
             onExternalDestroy: (destroyTooltip) => {
                 const handleUIStateChange: SharedInPageUIEvents['stateChanged'] = (
                     event,
@@ -199,6 +202,7 @@ export const insertTooltip = async (params: TooltipInsertDependencies) => {
             syncSettingsBG: params.syncSettingsBG,
             createHighlight: params.createHighlight,
             getWindow: () => window,
+            toggleTooltipState: params.toggleTooltipState,
         },
     )
 

diff --git a/src/in-page-ui/tooltip/types.ts b/src/in-page-ui/tooltip/types.ts
@@ -25,4 +25,5 @@ export interface TooltipDependencies extends AnnotationFunctions {
     pageActivityIndicatorBG: RemotePageActivityIndicatorInterface
     localStorageAPI: Storage.LocalStorageArea
     syncSettingsBG: RemoteSyncSettingsInterface
+    toggleTooltipState: (state: boolean) => Promise<void>
 }