Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config system rework #286

Open
mh-northlander opened this issue Dec 9, 2024 · 1 comment
Open

config system rework #286

mh-northlander opened this issue Dec 9, 2024 · 1 comment
Milestone

Comments

@mh-northlander
Copy link
Collaborator

current configuration system is a bit difficult to use: e.g. how the arguments of config::new(config_path, resource_dir, system_dict) interacts?

  • let it align with Java version
    • add PathAnchor to resolve resource file paths
  • embed default non-dictionary data to the binary
  • for Python, sudachipy.Config should be the main class for the configuration
@mh-northlander mh-northlander added this to the 0.7 milestone Dec 9, 2024
@eiennohito
Copy link
Collaborator

IMHO, Sudachi.rs does not need the PathAnchor functionality from Java because there is no classpath (albeit Python modules can serve as one). But I agree that in the current incarnation it is not clear how parameters interact.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants