Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CP-2245 Address triggering a failure in an interceptor (that could then be retried). #129

Open
evanweible-wf opened this issue Mar 4, 2016 · 0 comments

Comments

@evanweible-wf
Copy link
Contributor

A 200 OK response is not always equivalent to a successful state. Interceptors need to be able to trigger a failure state even when the request itself did not fail.

As currently implemented, interceptors can throw an exception to trigger a failure, and I think this is the approach I'd like to recommend. Regardless, the documentation needs to be updated to explicitly cover this use case.

fyi: @jeroencranendonk-wf

@evanweible-wf evanweible-wf modified the milestone: 2.4.1 May 24, 2016
@evanweible-wf evanweible-wf modified the milestones: 2.5.1, 2.6.1, 2.6.2 Jun 21, 2016
@evanweible-wf evanweible-wf modified the milestone: 2.7.2 Jun 29, 2016
@charliekump-wf charliekump-wf changed the title Address triggering a failure in an interceptor (that could then be retried). CP-2245 Address triggering a failure in an interceptor (that could then be retried). Jul 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant