From ede1af117f9fd2c795651f4665b27c1123ec769a Mon Sep 17 00:00:00 2001 From: Manuel Carrera Date: Wed, 8 Dec 2021 10:56:38 -0700 Subject: [PATCH] chore: Have verify action to wait on visual tests [skip release] (#1385) For a more accurate verify process, I've added `visual-testing` to the verify step as a dependency. [category:Infrastructure] --- .github/workflows/pull-request.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/pull-request.yml b/.github/workflows/pull-request.yml index 717a3398a7..df8b239f70 100644 --- a/.github/workflows/pull-request.yml +++ b/.github/workflows/pull-request.yml @@ -134,7 +134,7 @@ jobs: token: ${{ secrets.GITHUB_TOKEN }} appCode: dlpro96xybh storybookBuildDir: docs - exitOnceUploaded: true + exitOnceUploaded: false exitZeroOnChanges: true integration-test: @@ -183,7 +183,7 @@ jobs: verify: runs-on: ubuntu-latest - needs: ['check', 'integration-test'] + needs: ['check', 'integration-test', 'visual-test'] steps: - name: Done run: echo "Done"