Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVG icons for teams #16

Open
adamwoodnz opened this issue Oct 9, 2024 · 2 comments
Open

SVG icons for teams #16

adamwoodnz opened this issue Oct 9, 2024 · 2 comments

Comments

@adamwoodnz
Copy link
Contributor

adamwoodnz commented Oct 9, 2024

Replace team dashicons with SVGs to fix alignment issues and improve aesthetics.

I see some misalignments that seemed caused by the font and its x baseline. Here are some examples.

Section Header
Design Design header on Make page
Meta Meta header on Make page
Sustainability Sustainability header on Make page

Originally posted by @fcoveram in #2

Huh, that's a curious one indeed. It looks like there's nothing wrong with the CSS, but the globe in question is off-center in the Dashicons font itself.

Honestly it feels like an argument to update these icons to SVGs, and we can offer a consistent upgrade here to teams interested.

Originally posted by @jasmussen in #2

@adamwoodnz
Copy link
Contributor Author

@WordPress/meta-design are we good to use the icons in the Figma?

Image

@jasmussen
Copy link

I want to say yes, but I think there's a larger question that has to be posted in a Make announcement, an offer for the individual teams to update the icon, because those icons are used in additional places including swag and otherwise. So for now I would keep using the existing dashicons here, and then postpone the offer of helping with icon redesigns to a later sprint. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: On Hold/Blocked
Development

No branches or pull requests

2 participants