Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing downloader service in WP_Stream_Importer created from a cursor #2101

Open
zaerl opened this issue Dec 18, 2024 · 0 comments
Open

Missing downloader service in WP_Stream_Importer created from a cursor #2101

zaerl opened this issue Dec 18, 2024 · 0 comments
Labels
[Aspect] Data Liberation [Type] Bug An existing feature does not function as intended

Comments

@zaerl
Copy link
Collaborator

zaerl commented Dec 18, 2024

The npx nx run playground-data-liberation:test:wp-phpunit unit tests is failing on trunk 9ccd8be.

WPStream Importer Tests
 ✘ Resume frontloading
   │
   │ Failed asserting that null is of type int.
   │
   │ /wordpress/wp-content/plugins/data-liberation/tests/WPStreamImporterTests.php:89
   │ /internal/eval.php:14
   │

WP_Stream_Importer::downloader is not initialized when the importer starts from a cursor as in here. So the progress is always empty.
@zaerl zaerl added [Aspect] Data Liberation [Type] Bug An existing feature does not function as intended labels Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Aspect] Data Liberation [Type] Bug An existing feature does not function as intended
Projects
Playground Board
Status: Inbox
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zaerl