From 9c9e8695b43e553f3e30f72c0549787e83076863 Mon Sep 17 00:00:00 2001 From: Beatriz Fialho Date: Thu, 24 Oct 2024 16:37:34 +0100 Subject: [PATCH 01/11] Update heading font size --- patterns/cta-grid-products-link.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/patterns/cta-grid-products-link.php b/patterns/cta-grid-products-link.php index 216c81f1..b2f68ad4 100644 --- a/patterns/cta-grid-products-link.php +++ b/patterns/cta-grid-products-link.php @@ -17,7 +17,7 @@
-

+

From 5b7f071ddba3b692bb78724ab265f2d4883de132 Mon Sep 17 00:00:00 2001 From: Juan Aldasoro Date: Thu, 24 Oct 2024 18:40:20 +0200 Subject: [PATCH 02/11] Apply suggestions from code review --- patterns/cta-grid-products-link.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/patterns/cta-grid-products-link.php b/patterns/cta-grid-products-link.php index b2f68ad4..1d80247e 100644 --- a/patterns/cta-grid-products-link.php +++ b/patterns/cta-grid-products-link.php @@ -16,8 +16,8 @@
- -

+ +

From ef169d74188b0d5be5e735dce54da814dcd126af Mon Sep 17 00:00:00 2001 From: Peter Wilson Date: Wed, 23 Oct 2024 09:25:14 +1100 Subject: [PATCH 03/11] Add translator note for multilingual strings. --- patterns/banner-poster.php | 7 ++++++- patterns/cta-events-list.php | 14 ++++++++++++-- patterns/event-rsvp.php | 7 ++++++- 3 files changed, 24 insertions(+), 4 deletions(-) diff --git a/patterns/banner-poster.php b/patterns/banner-poster.php index 167ac0a8..f9d4ad05 100644 --- a/patterns/banner-poster.php +++ b/patterns/banner-poster.php @@ -21,7 +21,12 @@
-

+

+ +

diff --git a/patterns/cta-events-list.php b/patterns/cta-events-list.php index bb21168e..53b995fe 100644 --- a/patterns/cta-events-list.php +++ b/patterns/cta-events-list.php @@ -61,7 +61,12 @@
-

+

+ +

@@ -123,7 +128,12 @@
-

+

+ +

diff --git a/patterns/event-rsvp.php b/patterns/event-rsvp.php index e22b81e5..cf5cf5fa 100644 --- a/patterns/event-rsvp.php +++ b/patterns/event-rsvp.php @@ -23,7 +23,12 @@
-

+

+ +

From 9bec7bdb20a0471ca62cad22fa5ad260e81bced1 Mon Sep 17 00:00:00 2001 From: Peter Wilson Date: Wed, 23 Oct 2024 09:28:12 +1100 Subject: [PATCH 04/11] Use same context for sample/placeholder headings. --- patterns/banner-poster.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/patterns/banner-poster.php b/patterns/banner-poster.php index f9d4ad05..7e531cbf 100644 --- a/patterns/banner-poster.php +++ b/patterns/banner-poster.php @@ -24,7 +24,7 @@

From 0dcd053ec43ee52e4ee2a630b4ffed3c68e7c14e Mon Sep 17 00:00:00 2001 From: Peter Wilson Date: Fri, 25 Oct 2024 09:07:54 +1100 Subject: [PATCH 05/11] Update multilingual string to use `lang` attributes. --- patterns/banner-poster.php | 4 +++- patterns/cta-events-list.php | 8 ++++++-- patterns/event-rsvp.php | 6 ++++-- 3 files changed, 13 insertions(+), 5 deletions(-) diff --git a/patterns/banner-poster.php b/patterns/banner-poster.php index 7e531cbf..0c1ee173 100644 --- a/patterns/banner-poster.php +++ b/patterns/banner-poster.php @@ -23,8 +23,10 @@

historias, iсторії, iστορίες”', 'Placeholder heading in four languages.', 'twentytwentyfive' ) + ); ?>

diff --git a/patterns/cta-events-list.php b/patterns/cta-events-list.php index 53b995fe..4e91a24b 100644 --- a/patterns/cta-events-list.php +++ b/patterns/cta-events-list.php @@ -63,8 +63,10 @@

historias, iсторії, iστορίες”', 'Placeholder heading in four languages.', 'twentytwentyfive' ) + ); ?>

@@ -130,8 +132,10 @@

historias, iсторії, iστορίες”', 'Placeholder heading in four languages.', 'twentytwentyfive' ) + ); ?>

diff --git a/patterns/event-rsvp.php b/patterns/event-rsvp.php index cf5cf5fa..ec184346 100644 --- a/patterns/event-rsvp.php +++ b/patterns/event-rsvp.php @@ -24,9 +24,11 @@

- historias, iсторії, iστορίες”', 'Placeholder heading in four languages.', 'twentytwentyfive' ) + ); ?>

From da881fe46b7cec7f44c3a32b166f49cba3da5629 Mon Sep 17 00:00:00 2001 From: Peter Wilson Date: Fri, 25 Oct 2024 10:06:49 +1100 Subject: [PATCH 06/11] CS --- patterns/event-rsvp.php | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/patterns/event-rsvp.php b/patterns/event-rsvp.php index ec184346..beda4cb8 100644 --- a/patterns/event-rsvp.php +++ b/patterns/event-rsvp.php @@ -25,11 +25,11 @@

historias, iсторії, iστορίες”', 'Placeholder heading in four languages.', 'twentytwentyfive' ) - ); - ?> + echo wp_kses_post( + /* translators: This string contains the word "Stories" in four different languages with the first item in the locale's language. */ + _x( '“Stories, historias, iсторії, iστορίες”', 'Placeholder heading in four languages.', 'twentytwentyfive' ) + ); + ?>

From d73c8ad00dd34262a864df398ec54c37df030436 Mon Sep 17 00:00:00 2001 From: Peter Wilson <519727+peterwilsoncc@users.noreply.github.com> Date: Fri, 25 Oct 2024 12:24:00 +1100 Subject: [PATCH 07/11] Fix indentation inconsistency Co-authored-by: Sergey Biryukov --- patterns/event-rsvp.php | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/patterns/event-rsvp.php b/patterns/event-rsvp.php index beda4cb8..1ba58e5a 100644 --- a/patterns/event-rsvp.php +++ b/patterns/event-rsvp.php @@ -24,12 +24,12 @@

- historias, iсторії, iστορίες”', 'Placeholder heading in four languages.', 'twentytwentyfive' ) - ); - ?> + historias, iсторії, iστορίες”', 'Placeholder heading in four languages.', 'twentytwentyfive' ) + ); + ?>

From 4f9852b729ce91d2f0d4f9bf741deae49da1b4c0 Mon Sep 17 00:00:00 2001 From: Juan Aldasoro Date: Fri, 25 Oct 2024 16:16:31 +0200 Subject: [PATCH 08/11] Add parity to morning color. --- styles/colors/06-morning.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/styles/colors/06-morning.json b/styles/colors/06-morning.json index 491ce006..952d7733 100644 --- a/styles/colors/06-morning.json +++ b/styles/colors/06-morning.json @@ -192,7 +192,8 @@ }, ":hover": { "color": { - "background": "color-mix(in srgb, var(--wp--preset--color--accent-1) 85%, transparent)" + "background": "color-mix(in srgb, var(--wp--preset--color--accent-1) 85%, transparent)", + "text": "var:preset|color|contrast" } } }, From e3ec8c836f8dff24464007ff18b8aec0eccc0eea Mon Sep 17 00:00:00 2001 From: Juan Aldasoro Date: Fri, 25 Oct 2024 16:28:09 +0200 Subject: [PATCH 09/11] Fix parity for afternoon and typography preset 3. --- styles/typography/typography-preset-3.json | 57 ++++++++++------------ 1 file changed, 27 insertions(+), 30 deletions(-) diff --git a/styles/typography/typography-preset-3.json b/styles/typography/typography-preset-3.json index e4c051c8..4ff62975 100644 --- a/styles/typography/typography-preset-3.json +++ b/styles/typography/typography-preset-3.json @@ -32,20 +32,20 @@ }, { "fluid": { - "max": "2rem", - "min": "1.75rem" + "max": "1.8rem", + "min": "1.4rem" }, "name": "Extra Large", - "size": "1.75rem", + "size": "1.4rem", "slug": "x-large" }, { "fluid": { - "max": "3.625rem", - "min": "2.625rem" + "max": "2.6rem", + "min": "2rem" }, "name": "Extra Extra Large", - "size": "2.625rem", + "size": "2rem", "slug": "xx-large" } ] @@ -54,9 +54,8 @@ "styles": { "typography": { "fontFamily": "var:preset|font-family|ysabeau-office", - "fontWeight": "400", "letterSpacing": "-0.22px", - "lineHeight": "1.6" + "lineHeight": "1.5" }, "blocks":{ "core/code": { @@ -64,27 +63,17 @@ "letterSpacing": "0px" } }, - "core/list": { + "core/heading": { "typography": { - "lineHeight": "1.3" - } - }, - "core/loginout": { - "typography": { - "fontSize": "var:preset|font-size|medium" + "lineHeight": "1.2" } }, - "core/post-author": { - "typography": { - "fontSize": "var:preset|font-size|medium" - } - }, - "core/post-author-biography": { + "core/list": { "typography": { - "fontSize": "var:preset|font-size|medium" + "lineHeight": "1.3" } }, - "core/post-author-name": { + "core/loginout": { "typography": { "fontSize": "var:preset|font-size|medium" } @@ -94,12 +83,6 @@ "fontWeight": "400" } }, - "core/post-title": { - "typography": { - "fontWeight": "500", - "letterSpacing": "-0.8px" - } - }, "core/pullquote": { "typography": { "fontFamily": "var:preset|font-family|platypi", @@ -115,7 +98,7 @@ "core/site-title": { "typography": { "fontFamily": "var:preset|font-family|ysabeau-office", - "fontSize": "var:preset|font-size|medium", + "fontSize": "var:preset|font-size|large", "letterSpacing": "1.44px", "textTransform": "uppercase" } @@ -134,6 +117,20 @@ "typography": { "fontFamily": "var:preset|font-family|platypi" } + }, + "h5": { + "typography": { + "fontSize": "var:preset|font-size|medium" + } + }, + "h6": { + "typography": { + "fontSize": "var:preset|font-size|small", + "fontWeight": "400", + "fontStyle": "initial", + "letterSpacing": "initial", + "textTransform": "initial" + } } } } From fd977ae5c881a0ca424e4ac61bba28f4cba5264c Mon Sep 17 00:00:00 2001 From: Juan Aldasoro Date: Fri, 25 Oct 2024 16:32:25 +0200 Subject: [PATCH 10/11] Fix parity for sunrise and typography preset 6. --- styles/typography/typography-preset-6.json | 5 ----- 1 file changed, 5 deletions(-) diff --git a/styles/typography/typography-preset-6.json b/styles/typography/typography-preset-6.json index ab49e827..e21f2833 100644 --- a/styles/typography/typography-preset-6.json +++ b/styles/typography/typography-preset-6.json @@ -58,11 +58,6 @@ } } }, - "core/query-title": { - "typography": { - "fontWeight": "800" - } - }, "core/site-title": { "typography": { "fontFamily": "var:preset|font-family|platypi", From f88ba4712b7db5a5cb9cc5e7caf3d9d3afe81c4c Mon Sep 17 00:00:00 2001 From: Juan Aldasoro Date: Fri, 25 Oct 2024 16:35:25 +0200 Subject: [PATCH 11/11] Fix parity for midnight and typography preset 7. --- styles/colors/08-midnight.json | 10 ++++++++++ styles/typography/typography-preset-7.json | 2 ++ 2 files changed, 12 insertions(+) diff --git a/styles/colors/08-midnight.json b/styles/colors/08-midnight.json index efac06c7..70005a50 100644 --- a/styles/colors/08-midnight.json +++ b/styles/colors/08-midnight.json @@ -4,6 +4,16 @@ "title": "Midnight", "settings": { "color": { + "duotone": [ + { + "colors": [ + "#4433A6", + "#79F3B1" + ], + "name": "Midnight filter", + "slug": "midnight-filter" + } + ], "palette": [ { "color": "#4433A6", diff --git a/styles/typography/typography-preset-7.json b/styles/typography/typography-preset-7.json index 73285214..212df74b 100644 --- a/styles/typography/typography-preset-7.json +++ b/styles/typography/typography-preset-7.json @@ -99,7 +99,9 @@ "button": { "typography": { "fontFamily": "var:preset|font-family|literata", + "fontSize": "var:preset|font-size|medium", "fontWeight": "400", + "letterSpacing": "-0.01em", "textTransform": "uppercase" } },