Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle the plural form of subject titles #158

Open
psrpinto opened this issue Dec 12, 2024 · 6 comments
Open

Handle the plural form of subject titles #158

psrpinto opened this issue Dec 12, 2024 · 6 comments

Comments

@psrpinto
Copy link
Member

psrpinto commented Dec 12, 2024

The schema of a subject has a title:

// schema/subjects/blog-post.json
{
    "title": "Blog Post",
    ...
}

This title is used in the UI in its plural form, for example here.

We need to come up with a better way to handle the plural form of the title of a subject.

@psrpinto psrpinto added this to the MVP milestone Dec 12, 2024
@psrpinto
Copy link
Member Author

@akirk said:

one thing that we need is a plural term in the schema (see get_post_type_labels()),

@ashfame
Copy link
Member

ashfame commented Dec 12, 2024

Plural representation was also used in api endpoints itself. I specifically moved away from it in #153 but would use it to have plural names from schema, if available.

@psrpinto
Copy link
Member Author

Would you be ok with removing this from the MVP milestone @akirk @ashfame ? I think we can live with hardcoding it for now.

@akirk
Copy link
Member

akirk commented Dec 13, 2024

If it's not super quick then let's remove it.

@ashfame
Copy link
Member

ashfame commented Dec 13, 2024

Doesn't this just require adding a new field to schema? But fine to skip for MVP milestone.

@psrpinto
Copy link
Member Author

Ok, removing from milestone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants