Question about PluginCheck.CodeAnalysis.ImageFunctions.NonEnqueuedImage sniff

[jcvignoli]

Hi there,

I don't understand the point of this new PluginCheck.CodeAnalysis.ImageFunctions.NonEnqueuedImage as implemented there:

plugin-check/phpcs-sniffs/PluginCheck/Sniffs/CodeAnalysis/ImageFunctionsSniff.php

which results in Images should be added using wp_get_attachment_image() or similar functions

For many of the WP plugins makers , we add images in the WP admin backoffice. Those images are not uploaded to WP gallery, but rather static files called the good old way with an . There is no way to bypass the regex, which will detect any in the plugin.

It is my understanding you're going to change it a warning, as discussed here #757 but I'm questionning even such a warning. To my understanding, even a warning is not appropriate for plugins makers.

Even if the aim is undertandable, in practice it doesn't make sense to me.