Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added check for duplicated file names #711

Open
wants to merge 7 commits into
base: trunk
Choose a base branch
from
Open

Added check for duplicated file names #711

wants to merge 7 commits into from

Conversation

davidperezgar
Copy link
Member

Fixes #710

@davidperezgar davidperezgar linked an issue Oct 9, 2024 that may be closed by this pull request
Check: Look for duplicated filenames #710
Open
@davidperezgar
Copy link
Member Author

@swissspidy this is the part of badly names that suggested @ernilambar to move it away, so we can work on reflection tests.

@davidperezgar davidperezgar added the Needs Testing Anything that needs testing from a developer perspective label Nov 3, 2024
@ernilambar
Copy link
Member

ernilambar commented Nov 22, 2024 •
edited
Loading

@davidperezgar I have updated the test for the check. But I noticed current check does not account for the duplicated folder name. Example:

UNIT_TESTS_PLUGIN_DIR . 'test-plugin-file-type-badly-named-files-errors/sub directory/file-1.php'
UNIT_TESTS_PLUGIN_DIR . 'test-plugin-file-type-badly-named-files-errors/Sub Directory/file-2.php'

I think we should also check for folder. We should refine the check along with error code - "duplicated_files"

@davidperezgar
Copy link
Member Author

Hey awesome! It's ready then to review!

@davidperezgar davidperezgar marked this pull request as ready for review November 22, 2024 19:00
@github-actions GitHub Actions
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: davidperezgar <[email protected]>
Co-authored-by: ernilambar <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barrykooij barrykooij Awaiting requested review from barrykooij barrykooij is a code owner

@ernilambar ernilambar Awaiting requested review from ernilambar ernilambar is a code owner

@frantorres frantorres Awaiting requested review from frantorres frantorres is a code owner

@chriscct7 chriscct7 Awaiting requested review from chriscct7 chriscct7 is a code owner

@swissspidy swissspidy Awaiting requested review from swissspidy

@felixarntz felixarntz Awaiting requested review from felixarntz

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
Needs Testing Anything that needs testing from a developer perspective
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check: Look for duplicated filenames
2 participants
@davidperezgar @ernilambar