Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump minimum required WordPress version to 6.6 #1683

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

Bump minimum required WordPress version to 6.6 #1683

wants to merge 2 commits into from

Conversation

mukeshpanchal27
Copy link
Member

Summary

Fixes #1682

@mukeshpanchal27 mukeshpanchal27 added [Type] Enhancement A suggestion for improvement of an existing feature Infrastructure Issues for the overall performance plugin infrastructure skip changelog PRs that should not be mentioned in changelogs labels Nov 20, 2024
@mukeshpanchal27 mukeshpanchal27 self-assigned this Nov 20, 2024
@mukeshpanchal27 mukeshpanchal27 removed this from the performance-lab n.e.x.t milestone Nov 20, 2024
@mukeshpanchal27 mukeshpanchal27 marked this pull request as ready for review November 20, 2024 14:36
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 20, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: mukeshpanchal27 <[email protected]>
Co-authored-by: westonruter <[email protected]>
Co-authored-by: felixarntz <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

felixarntz
felixarntz requested changes Nov 20, 2024
View reviewed changes
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per the discussion in #1682, I don't see a good reason to bump the required WordPress version, even less so to 6.6 because the latest release is 6.7.

Let's continue discussion in the issue to determine what we want to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixarntz felixarntz felixarntz requested changes

@westonruter westonruter westonruter approved these changes

@adamsilverstein adamsilverstein Awaiting requested review from adamsilverstein adamsilverstein is a code owner

@pbearne pbearne Awaiting requested review from pbearne pbearne is a code owner

@joemcgill joemcgill Awaiting requested review from joemcgill joemcgill is a code owner

@thelovekesh thelovekesh Awaiting requested review from thelovekesh thelovekesh is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

@mukeshpanchal27 mukeshpanchal27

Labels
blocked Infrastructure Issues for the overall performance plugin infrastructure skip changelog PRs that should not be mentioned in changelogs [Type] Enhancement A suggestion for improvement of an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bump minimum required WordPress version to 6.6
3 participants
@mukeshpanchal27 @westonruter @felixarntz