Only check plugin version integrity in deployment workflow if the plugin actually requires to be deployed

[felixarntz]

Summary

See #1664: This PR attempts to properly fix the underlying issue: We shouldn't check the version integrity of plugins that do not need deployment during the deployment workflow.

Therefore, this PR moves that check after the conditional for whether a deployment is needed. This will still catch problems for any plugins that need to be deployed, but ignore problems from other plugins (which may temporarily exist, and that's okay).

The PR also effectively reverts the short-term fix from #1664, re-including those future changelog entries, as they should no longer be a problem after this.

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: felixarntz <[email protected]>
Co-authored-by: westonruter <[email protected]>
Co-authored-by: mukeshpanchal27 <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[mukeshpanchal27]

Thanks for the PR. LGTM. Left one non-blocking feedback.

[mukeshpanchal27]

Not blocker: Instead of adding if: steps.check-deployment.outputs.deploy == 'true' condition in every steps can we add new step if output is not true the exit and remove condition from all other steps below?

[felixarntz]

Not sure how that would work in GitHub Actions. Maybe it's possible, but I'm not sure there's a way to properly exit out of a GitHub workflow. Do you have an idea about it?

[mukeshpanchal27]

We can add the below new step after the Check if deployment is needed step and we can remove the if: steps.check-deployment.outputs.deploy == 'true' condition from all other steps after adding these step.

- name: Fail early if deployment check is false
  if: steps.check-deployment.outputs.deploy != 'true'
  run: |
    echo "Deployment condition not met. Exiting."
    exit 1

I did test in my folk repo - https://github.com/mukeshpanchal27/performance/actions/runs/11926864996/job/33241344801

[felixarntz]

@swissspidy Curious what's your take on the idea of early returns/exits in GitHub workflows.