Speculative Loading: Two <script type="speculationrules"> tags?

[TobiasBg]

Bug Description

I just tested the Speculative Loading plugin, version 1.4.0, on WP 6.8-beta1-59953 (because I'm interested in the moderate eagerness).

Now, I might be misunderstanding something, but it doesn't seem right that the plugin adds a second <script type="speculationrules"> tag (for prerender, with moderate) in addition to the one (for prefetch with conservative) that WP 6.8 adds. I would have expected that the plugin replaces the one from WP?

This is what I'm getting in the frontend HTML:

<script type="speculationrules">
{"prefetch":[{"source":"document","where":{"and":[{"href_matches":"\/*"},{"not":{"href_matches":["\/wp-*.php","\/wp-admin\/*","\/wp-content\/uploads\/*","\/wp-content\/*","\/wp-content\/plugins\/*","\/wp-content\/themes\/ollie\/*","\/*\\?(.+)"]}},{"not":{"selector_matches":"a[rel~=\"nofollow\"]"}},{"not":{"selector_matches":".no-prefetch, .no-prefetch a"}}]},"eagerness":"conservative"}]}
</script>
<script type="speculationrules">
{"prerender":[{"source":"document","where":{"and":[{"href_matches":"\/*"},{"not":{"href_matches":["\/wp-*.php","\/wp-admin\/*","\/wp-content\/uploads\/*","\/wp-content\/*","\/wp-content\/plugins\/*","\/wp-content\/themes\/ollie\/*","\/*\\?(.+)"]}},{"not":{"selector_matches":"a[rel~=\"nofollow\"]"}},{"not":{"selector_matches":".no-prerender"}}]},"eagerness":"moderate"}]}
</script>

(The prerender with moderate works fine, according to the Chrome Dev Tools, it's just the duplicated <script> tag that I find odd. Or is that because of the slightly different "not":{"selector_matches":...} rules?)

[westonruter]

Ah yes, the issue is that we haven't yet released a new version of the Speculative Loading plugin that accounts for the feature in 6.8-beta1. See #1883.

[TobiasBg]

Totally makes sense, my bad! I had checked the code here in the repo and was confused that this was happening despite seeing if ( function_exists( 'wp_get_speculation_rules_configuration' ) ) { -- it didn't occur to me that the wp.org version might be different to this repo...

I assume that a new release will happen in time for WP 6.8 so that this issue can probably be closed, unless it should serve as a reminder.

[westonruter]

Yes, we'll be releasing the new version of the plugin in a couple weeks. I'll try to make a ZIP build of the plugin later and attach it here later today for you to use in the meantime.

[westonruter]

@TobiasBg Here's a build of the plugin from trunk (at 1a7f906) you can use that includes the aforementioned PR merged: speculation-rules.zip

[TobiasBg]

Thanks, @westonruter!