Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable end user opt-in to generate all sizes in fallback format #1513

Open
adamsilverstein opened this issue Aug 29, 2024 · 3 comments · May be fixed by #1689
Open

Enable end user opt-in to generate all sizes in fallback format #1513

adamsilverstein opened this issue Aug 29, 2024 · 3 comments · May be fixed by #1689
Assignees
Labels
Good First Issue Issue particularly suitable to be worked on by new contributors [Plugin] Modern Image Formats Issues for the Modern Image Formats plugin (formerly WebP Uploads) [Type] Enhancement A suggestion for improvement of an existing feature

Comments

@adamsilverstein
Copy link
Member

adamsilverstein commented Aug 29, 2024

Feature Description

As discussed in #1421 when "generate fallback images" is enabled, we only generate the core default sizes in the fallback format. The reasoning here is that users can have many sizes and generating all of the sub-sizes can require an unexpectedly large amount of storage for users. I am unsure about this so let's give users the option to generate all sizes.

This proposal is to add a checkbox users can check right below the "generate fallback images" checkbox (and it would only be enabled when that checkbox is checked). Similar the the generate fallback checkbox, the note would indicate this requires even more disk space.

Something like:

 - [ ] **Generate fallback images in all sizes including custom sizes** 
 * Note: uses even more storage space.

Ideally when users enable this feature we should notate that in the Generator tag so we can later discover how many sites opt into generating all image sizes.

@github-project-automation github-project-automation bot moved this to Not Started/Backlog 📆 in WP Performance 2024 Aug 29, 2024
@adamsilverstein adamsilverstein added [Type] Enhancement A suggestion for improvement of an existing feature [Plugin] Modern Image Formats Issues for the Modern Image Formats plugin (formerly WebP Uploads) labels Aug 29, 2024
@adamsilverstein adamsilverstein added the Good First Issue Issue particularly suitable to be worked on by new contributors label Aug 30, 2024
@adamsilverstein adamsilverstein self-assigned this Sep 9, 2024
@adamsilverstein adamsilverstein moved this from Not Started/Backlog 📆 to To Do 🔧 in WP Performance 2024 Sep 9, 2024
@b1ink0
Copy link
Contributor

b1ink0 commented Nov 12, 2024

Hi, I am interested in working on this issue can it be assigned to me.

@b1ink0
Copy link
Contributor

b1ink0 commented Nov 20, 2024

@adamsilverstein @felixarntz

I was trying to implement the required feature but I am facing confusion about the generate all sizes option.

Currently if I add these custom sizes

add_image_size( 'custom_size_1', 400, 400, true );
add_image_size( 'custom_size_2', 800, 800, true );
add_image_size( 'custom_size_3', 1200, 1200, true );

When the output fallback images is enabled these are the images generated for a demo img.
Image

When the new proposed output all fallback images is enabled are these the images that should be generated?
Image

@felixarntz
Copy link
Member

@b1ink0 Yes, that's correct. If the new option is enabled, all existing image sizes should receive a converted file in the modern image formats, whereas the default only covers the WordPress Core built-in sizes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue Issue particularly suitable to be worked on by new contributors [Plugin] Modern Image Formats Issues for the Modern Image Formats plugin (formerly WebP Uploads) [Type] Enhancement A suggestion for improvement of an existing feature
Projects
Status: To Do 🔧
Development

Successfully merging a pull request may close this issue.

3 participants