Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Module Proposal: Add object caching information to site health #718

Open
spacedmonkey opened this issue Apr 25, 2023 · 4 comments · May be fixed by #1301
Open

Module Proposal: Add object caching information to site health #718

spacedmonkey opened this issue Apr 25, 2023 · 4 comments · May be fixed by #1301
Assignees
@spacedmonkey
Labels
[Plugin] Performance Lab Issue relates to work in the Performance Lab Plugin only [Plugin] Persistent Object Cache Issues for the Persistent Object Cache Health Check module

Comments

@spacedmonkey
Copy link
Member

Overview

  • Proposed module name: Site health object cache information.
  • Proposed module slug: site-health-object-cache
  • Proposed module owner GitHub username(s):

About the module

Purpose

Add some basic information to the site health screen containing type of object cache that is in use. Add a list of features that wp_cache_supports function returns, with a boolean response. This information will make it clear what feature your object cache supports and if object caching is in use.

A mockup of what this might look like.

Screenshot 2023-04-25 at 15 16 09

Scope

Rationale

Other
@spacedmonkey spacedmonkey added [Focus] Object Cache [Plugin] Persistent Object Cache Issues for the Persistent Object Cache Health Check module labels Apr 25, 2023
@spacedmonkey spacedmonkey self-assigned this Apr 25, 2023
@OllieJones
Copy link
Contributor

OllieJones commented Apr 25, 2023 •
edited
Loading

Good stuff. See wp-cli/cache-command#68 (comment) for an idea about how to get the information you need.

It might (???) be good to have your module call some sort of $wp_object_cache->usage_stats() function if it's defined. That could, at the option of the drop-in author, spit back some usage info for display in the module. There's a plain old ->stats() function but I don't think anybody calls it.

These ideas all involve persuading drop-in authors to add a few public functions.

Your proposal is fine as-is. I'm just brainstorming a few extra things, things I would use.

@tillkruss
Copy link
Member

tillkruss commented Apr 25, 2023 •
edited
Loading

@OllieJones: I've talked with @johnbillion about this, since Query Monitor reads a lot of object caching metrics. We need a standard, ideally in core, that clearly outlines what's returned. We could even call it wp_cache_info()

@tillkruss
Copy link
Member

@spacedmonkey: I'll gladly take this proposal.

@spacedmonkey spacedmonkey mentioned this issue Apr 26, 2023
Closed
1 task
@felixarntz felixarntz added the [Plugin] Performance Lab Issue relates to work in the Performance Lab Plugin only label Jul 19, 2023
@adamsilverstein
Copy link
Member

we are working on this today at WCEU Contributor day

mkurdybanowski added a commit to mkurdybanowski/performance that referenced this issue Jun 13, 2024
@mkurdybanowski
WordPress#718: object caching info
37fe48b
@mkurdybanowski mkurdybanowski linked a pull request Jun 13, 2024 that will close this issue
Open
mkurdybanowski added a commit to mkurdybanowski/performance that referenced this issue Jul 25, 2024
@mkurdybanowski
WordPress#718: Fix lint and phpstan errors
061657f
mkurdybanowski added a commit to mkurdybanowski/performance that referenced this issue Jul 25, 2024
@mkurdybanowski
WordPress#718: Fix CR issues
dd59b4c
mkurdybanowski added a commit to mkurdybanowski/performance that referenced this issue Jul 25, 2024
@mkurdybanowski
WordPress#718: Fix prefix
d746d31
mkurdybanowski added a commit to mkurdybanowski/performance that referenced this issue Jul 25, 2024
@mkurdybanowski
WordPress#718: Fix prefix
b2a3c87
mkurdybanowski added a commit to mkurdybanowski/performance that referenced this issue Jul 29, 2024
@mkurdybanowski
WordPress#718: globals in docBlock
74897bb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spacedmonkey spacedmonkey

Labels
[Plugin] Performance Lab Issue relates to work in the Performance Lab Plugin only [Plugin] Persistent Object Cache Issues for the Persistent Object Cache Health Check module
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Site Health test for Object Caching mkurdybanowski/performance
6 participants
@spacedmonkey @tillkruss @adamsilverstein @felixarntz @OllieJones @sstopfer