Merge pull request #1378 from dhananjaykuber/fix/1375-prevent-jpeg-output-when-disabled

adamsilverstein · web-flow · commit 58447e08e19c · 2024-07-22T09:54:51.000-06:00
WebP Uploads: Prevent picture element when JPEG output is disabled
diff --git a/plugins/webp-uploads/helper.php b/plugins/webp-uploads/helper.php
@@ -393,7 +393,7 @@ function webp_uploads_sanitize_image_format( string $image_format ): string {
  * @return bool True if the option is enabled, false otherwise.
  */
 function webp_uploads_is_picture_element_enabled(): bool {
-	return (bool) get_option( 'webp_uploads_use_picture_element', false );
+	return webp_uploads_is_jpeg_fallback_enabled() && (bool) get_option( 'webp_uploads_use_picture_element', false );
 }
 
 /**

Original file line number	Diff line number	Diff line change
`@@ -393,7 +393,7 @@ function webp_uploads_sanitize_image_format( string $image_format ): string {`
`393`	`393`	`* @return bool True if the option is enabled, false otherwise.`
`394`	`394`	`*/`
`395`	`395`	`function webp_uploads_is_picture_element_enabled(): bool {`
`396`		`- return (bool) get_option( 'webp_uploads_use_picture_element', false );`
	`396`	`+ return webp_uploads_is_jpeg_fallback_enabled() && (bool) get_option( 'webp_uploads_use_picture_element', false );`
`397`	`397`	`}`
`398`	`398`
`399`	`399`	`/**`