Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should core patterns live in the directory? #81

Closed
tellyworth opened this issue Apr 20, 2021 · 1 comment
Closed

Should core patterns live in the directory? #81

tellyworth opened this issue Apr 20, 2021 · 1 comment
Labels
[Type] Discussion Proposed idea, needs input from others before actionable

Comments

@tellyworth
Copy link

For consistency of search, we could include all core patterns in the pattern directory, and return them as part of API search results. That would eliminate the need to separately search core patterns locally on the user's site, and enable us to consistently apply search ranking and filtering across both third party and core patterns.

Patterns registered by a plugin or theme would still need to be searched locally though. Unless we implemented discovery and indexing of patterns found in the plugin and theme directories (which wouldn't cover plugins or themes hosted elsewhere). It might make sense for plugin and theme patterns to be grouped separately from others though - I could see it being useful to group each plugin's patterns together.

@tellyworth tellyworth added the [Type] Discussion Proposed idea, needs input from others before actionable label Apr 20, 2021
@ryelle
Copy link
Contributor

ryelle commented Apr 20, 2021

Core patterns have already been loaded into wp.org/patterns 👍🏻 (I even have a draft PR into gutenberg to transparently replace the existing patterns with these API results, but then we started talking about redesigning the editor search…)

@iandunn started a discussion about how to combine locally-registered patterns with the API patterns/how to display those over on the gutenberg repo: WordPress/gutenberg#28248

@ryelle ryelle closed this as completed Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Discussion Proposed idea, needs input from others before actionable
Projects
None yet
Development

No branches or pull requests

2 participants