Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Border color isn't respected across blocks #718

Open
annezazu opened this issue Dec 15, 2024 · 1 comment
Open

Border color isn't respected across blocks #718

annezazu opened this issue Dec 15, 2024 · 1 comment
Labels
[Component] Pattern Creator Anything related to the pattern front end editor or preview

Comments

@annezazu
Copy link
Collaborator

Describe the bug

When trying to set a border, the border color isn't respected. I can replicate across image and columns blocks.

To Reproduce

  1. Add an image.
  2. Open tools panel.
  3. Set a border and set a color.
  4. Notice the color doesn't appear

Expected behavior

I can control border color.

Screenshots

border.color.broken.mov
@ryelle
Copy link
Contributor

ryelle commented Dec 17, 2024

This is due to the fact that none of the custom properties are loaded in the editor window, and for some reason, only when the sides are unlinked, the border-color uses the custom property. On the frontend, the color loads correctly (for the default colors— the "theme" colors should not be visible there, as it's a different theme than the one used by the previewer).

Editor Frontend
Image Image

So there's the larger issue of the Pattern Directory theme "leaking" into the creator — previously there was code to use Twenty Twenty-Three (IIRC) when initializing the creator, but I bet more settings are being loaded async somehow instead of using the config we set. So instead it's loading the Pattern Directory theme, which is causing other issues (#710, #618, etc).

But that doesn't really explain why the custom properties are not set at all… something likely changed with how GB loads assets, so however the pattern creator had been doing it isn't working anymore.

I tried rolling back to 18.7 & 17.9 and I still saw these issues, so this isn't a new regression.

@ryelle ryelle added the [Component] Pattern Creator Anything related to the pattern front end editor or preview label Dec 17, 2024
@ryelle ryelle moved this to ⚠ On Hold/Blocked in WordPress.org Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Component] Pattern Creator Anything related to the pattern front end editor or preview
Projects
Status: On Hold/Blocked
Development

No branches or pull requests

2 participants