Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pattern Details: Remove restricted height or increase max-height #381

Closed
shaunandrews opened this issue Nov 22, 2021 · 2 comments
Closed
Labels
[Component] Theme The frontend of the pattern directory, pattern lists UI

Comments

@shaunandrews
Copy link
Collaborator

Currently, the preview on the pattern detail page (i.e. https://wordpress.org/patterns/pattern/large-background-image-with-title-and-description/) has set height of 50vh, which for many patterns causes an additional scrollbar:

image

It would be better if we could display the entire pattern without needing to scroll within the overall page. Instead of a fixed height, maybe we can switch to a max-height with a much larger value like 200vh.

This might introduce some issues with the drag handles; With the current behavior the drag handles could render outside the viewport. To fix this, I think we'd have to add some logic to ensure the drag handles always appear inside the viewport.

@ryelle
Copy link
Contributor

ryelle commented Jan 6, 2022

I think this would be fixed by switching to the component suggested in #380, but I'll leave this open too just to make sure.

@ryelle ryelle added the [Component] Theme The frontend of the pattern directory, pattern lists UI label Jan 6, 2022
@ryelle ryelle added this to the Later milestone Jan 6, 2022
@ryelle ryelle modified the milestones: Later, Directory Cleanup Feb 22, 2022
@ryelle
Copy link
Contributor

ryelle commented Apr 18, 2024

Closing this, after much discussion with the site refresh (#635 (comment) & #650), it's required that we have a fixed-height viewport for previews. #672 is open to potentially update this on smaller screens.

@ryelle ryelle closed this as not planned Won't fix, can't repro, duplicate, stale Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Component] Theme The frontend of the pattern directory, pattern lists UI
Projects
None yet
Development

No branches or pull requests

2 participants