You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It would be better if we could display the entire pattern without needing to scroll within the overall page. Instead of a fixed height, maybe we can switch to a max-height with a much larger value like 200vh.
This might introduce some issues with the drag handles; With the current behavior the drag handles could render outside the viewport. To fix this, I think we'd have to add some logic to ensure the drag handles always appear inside the viewport.
The text was updated successfully, but these errors were encountered:
Closing this, after much discussion with the site refresh (#635 (comment) & #650), it's required that we have a fixed-height viewport for previews. #672 is open to potentially update this on smaller screens.
Currently, the preview on the pattern detail page (i.e. https://wordpress.org/patterns/pattern/large-background-image-with-title-and-description/) has set height of
50vh
, which for many patterns causes an additional scrollbar:It would be better if we could display the entire pattern without needing to scroll within the overall page. Instead of a fixed height, maybe we can switch to a
max-height
with a much larger value like200vh
.This might introduce some issues with the drag handles; With the current behavior the drag handles could render outside the viewport. To fix this, I think we'd have to add some logic to ensure the drag handles always appear inside the viewport.
The text was updated successfully, but these errors were encountered: