Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme: Query results show translated patterns side by side. #273

Closed
StevenDufresne opened this issue Jul 7, 2021 · 6 comments · Fixed by #278
Closed

Theme: Query results show translated patterns side by side. #273

StevenDufresne opened this issue Jul 7, 2021 · 6 comments · Fixed by #278
Assignees
Labels
[Component] Theme The frontend of the pattern directory, pattern lists UI i18n Translations and internationalization of patterns

Comments

@StevenDufresne
Copy link
Collaborator

StevenDufresne commented Jul 7, 2021

Describe the bug
I'm not sure if it's enclosed in another ticket but I'll add this in case.

Since we now have translated patterns, the search results are showing translated versions of the same pattern making the pattern list a bit useless.

To Reproduce
Steps to reproduce the behavior:

  1. Go to wordpress.org/patterns
  2. View the result list, expect to see the same patterns in different languages.

Expected behavior
We should only see patterns matching our locale.

Screenshots

Desktop (please complete the following information):

  • OS: macOs
  • Browser Chrome
  • Version July 7, latest :)
@ryelle ryelle added [Component] Theme The frontend of the pattern directory, pattern lists UI i18n Translations and internationalization of patterns labels Jul 7, 2021
@ryelle ryelle added this to the Initial Launch milestone Jul 7, 2021
@ryelle
Copy link
Contributor

ryelle commented Jul 7, 2021

I had thought there was an issue for this, but it looks like I misread #244, and that's just about the api.wordpress.org endpoint. @iandunn, you've been working on this concept for #244, is this on your radar at all?

@iandunn
Copy link
Member

iandunn commented Jul 8, 2021

Ah, no, I was just focused on api.w.org, but should have thought of this too. I'm working on #28 right now, but can circle back to this after that.

@kjellr
Copy link
Collaborator

kjellr commented Jul 8, 2021

This is also happening in the Gutenberg plugin — all translations are showing up at once in the inserter. Should I open a separate issue for this, or will it be resolved by whatever change would fix display in the directory too?

patterns

@iandunn
Copy link
Member

iandunn commented Jul 8, 2021

The Gutenberg issue should be fixed once WordPress/gutenberg#33052 is merged; it's currently waiting on review.

If you disable Gutenberg and just use 5.8-RC2, you should see the locale-specific results.

@kjellr
Copy link
Collaborator

kjellr commented Jul 8, 2021

Awesome, thanks. 🙌

@iandunn
Copy link
Member

iandunn commented Jul 8, 2021

circle back to this after that

Nevermind, I'm at a good stopping place w/ the search, so switching to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Component] Theme The frontend of the pattern directory, pattern lists UI i18n Translations and internationalization of patterns
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants