Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two buttons pattern block validation error #245

Closed
Mamaduka opened this issue Jun 30, 2021 · 5 comments · Fixed by WordPress/gutenberg#33117
Closed

Two buttons pattern block validation error #245

Mamaduka opened this issue Jun 30, 2021 · 5 comments · Fixed by WordPress/gutenberg#33117

Comments

@Mamaduka
Copy link
Member

Describe the bug
The "Two buttons" pattern triggers a validation error with 5.8 RC1. It looks like the pattern is using old markup - WordPress/gutenberg#21923.

To Reproduce
Steps to reproduce the behavior:

  1. Update to WP 5.8 RC1
  2. Create or edit a post.
  3. See validation errors in the console.

Expected behavior
Core patterns shouldn't trigger validation errors.

Screenshots
CleanShot 2021-06-30 at 09 37 14

@jasmussen
Copy link

I'm also seeing this one causing a consistent test failure in this unrelated PR: WordPress/gutenberg#33062

Screenshot 2021-06-30 at 09 31 17

@kjellr
Copy link
Collaborator

kjellr commented Jun 30, 2021

@ryelle as per WordPress/gutenberg#28800, this one is getting pulled in via the API now, right?

I double checked the markup and it's not throwing any errors in the editor itself. I even fully re-created it to be sure. 🤷‍♂️ I did notice that it's marked as "unlisted" here in the pattern directory, and I'm not sure why that is.

@Mamaduka
Copy link
Member Author

@kjellr I think that's a temp solution to avoid failing e2e tests see - https://wordpress.slack.com/archives/C02QB2JS7/p1625051015138400?thread_ts=1625031663.134000&cid=C02QB2JS7.

Also, @ntsekouras might have updated the pattern.

@ntsekouras
Copy link

ntsekouras commented Jun 30, 2021

@kjellr I think that's a temp solution to avoid failing e2e tests see -

Exactly. For now this is why it stopped failing. I'm back and forth with different kind of failures today and haven't pinpointed the root cause for this 😄

@ntsekouras
Copy link

This issue can be closed now that the PR was merged. I just realized it was an issue for the directory and not GB 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants