-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Two buttons pattern block validation error #245
Comments
I'm also seeing this one causing a consistent test failure in this unrelated PR: WordPress/gutenberg#33062 |
@ryelle as per WordPress/gutenberg#28800, this one is getting pulled in via the API now, right? I double checked the markup and it's not throwing any errors in the editor itself. I even fully re-created it to be sure. 🤷♂️ I did notice that it's marked as "unlisted" here in the pattern directory, and I'm not sure why that is. |
@kjellr I think that's a temp solution to avoid failing e2e tests see - https://wordpress.slack.com/archives/C02QB2JS7/p1625051015138400?thread_ts=1625031663.134000&cid=C02QB2JS7. Also, @ntsekouras might have updated the pattern. |
Exactly. For now this is why it stopped failing. I'm back and forth with different kind of failures today and haven't pinpointed the root cause for this 😄 |
This issue can be closed now that the PR was merged. I just realized it was an issue for the directory and not GB 😄 |
Describe the bug
The "Two buttons" pattern triggers a validation error with 5.8 RC1. It looks like the pattern is using old markup - WordPress/gutenberg#21923.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Core patterns shouldn't trigger validation errors.
Screenshots

The text was updated successfully, but these errors were encountered: