Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pattern Directory support to the core editor #10

Closed
tellyworth opened this issue Nov 6, 2020 · 3 comments
Closed

Add Pattern Directory support to the core editor #10

tellyworth opened this issue Nov 6, 2020 · 3 comments
Labels
[Component] Core/Gutenberg Changes that should happen in the core editor (tracking issues only) [Type] Tracking Issue
Milestone

Comments

@tellyworth
Copy link

tellyworth commented Nov 6, 2020

The core editor should allow users to search and insert block patterns from the pattern directory, in a similar way to the block directory.

Tentative assumptions:

  • Unlike block plugins there is probably no "install" step needed. Patterns from the directory can simply be inserted into a post exactly as core patterns work at present.
  • Core patterns might be moved to the Pattern Directory, so they can be improved independent of the core release schedule.
  • A local REST API endpoint for searching the pattern directory might be needed, in a similar manner to the block directory endpoint. (Stub Core endpoint #3)
  • Patterns from the directory can probably be listed in the same UI as core patterns are at present.

This is an umbrella task, specific issues should be created as needed.

@ryelle
Copy link
Contributor

ryelle commented Nov 9, 2020

I un-checklisted the assumption list since they're not actions. From here, I see the action(s) as

In past conversations we haven't discussed changing the patterns UI, only the backend data source, so I think that's still a safe assumption.

@ryelle ryelle added the [Component] Core/Gutenberg Changes that should happen in the core editor (tracking issues only) label Nov 12, 2020
@iandunn
Copy link
Member

iandunn commented Nov 24, 2020

The Core patterns are all imported into the CPT now. I left the box above unchecked since we haven't removed them from Core yet.

Although, I'd be tempted to just mark the wp-includes/block-patterns/ as deprecated, but leave them permanently 🤔

Removing them would cause fatals for any plugins that are requreing them.

@iandunn
Copy link
Member

iandunn commented Dec 1, 2020

I separated importing and removing into separate checklist items, so the checklist can reflect what's done and what's not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Component] Core/Gutenberg Changes that should happen in the core editor (tracking issues only) [Type] Tracking Issue
Projects
None yet
Development

No branches or pull requests

3 participants