Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect slug for Kyrgyz locale #5059

Open
obulat opened this issue Oct 21, 2024 · 0 comments · May be fixed by #5177
Open

Incorrect slug for Kyrgyz locale #5059

obulat opened this issue Oct 21, 2024 · 0 comments · May be fixed by #5177
Labels
📄 aspect: text Concerns the textual material in the repository 🛠 goal: fix Bug fix 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: frontend Related to the Nuxt frontend

Comments

@obulat
Copy link
Contributor

obulat commented Oct 21, 2024

Description

Kyrgyz locale should have ky as slug, but in Openverse we incorrectly use kir.

According to Chrome for Developers documentation, hreflang should use ISO 639-1 code for language, which is ky 1, 2.

This value comes from GlotPress:

https://github.com/GlotPress/GlotPress/blob/0de4f9656a954132becffbccca8cc336143c93e2/locales/locales.php#L1604-L1614

Screenshots

The error as reported by Lighthouse:

Image

Additional context

The latest change to Kyrgyz locale properties in GlotPress were done in Update Kyrgyz locale information. However, the changes don't fully match the locale editor request.

Footnotes

  1. https://en.wikipedia.org/wiki/List_of_ISO_639_language_codes ↩

  2. https://www.loc.gov/standards/iso639-2/php/langcodes_name.php?iso_639_1=ky ↩
@obulat obulat added 📄 aspect: text Concerns the textual material in the repository 🛠 goal: fix Bug fix 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: frontend Related to the Nuxt frontend labels Oct 21, 2024
@openverse-bot openverse-bot moved this to 📋 Backlog in Openverse Backlog Oct 21, 2024
@obulat obulat mentioned this issue Oct 29, 2024
Open
@obulat obulat linked a pull request Nov 22, 2024 that will close this issue
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
📄 aspect: text Concerns the textual material in the repository 🛠 goal: fix Bug fix 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: frontend Related to the Nuxt frontend
Projects
Openverse Backlog
Status: 📋 Backlog
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rewrite the i18n scripts WordPress/openverse
1 participant
@obulat