This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Try splitting bundle size reporting #1378
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Storybook and Tailwind configuration previews: Ready Storybook: https://wordpress.github.io/openverse-frontend/1378 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. |
openverse-bot
added
the
🚦 status: awaiting triage
sarayourfriend
added
🟩 priority: low
|
It is failing on the |
sarayourfriend
force-pushed
the
try/split-bundle-size-report
branch
from
1ba13ab
to
abd14ca
Compare
|
It's still stuck using the old |
sarayourfriend
force-pushed
the
try/split-bundle-size-report
branch
from
abd14ca
to
4d504ec
Compare
|
Size Change: +2 B (0%) Total Size: 681 kB
ℹ️ View Unchanged
|
|
As I suspected, it's only capable of a single comment 😢 You can see in the edit history of the comment where it overwrote itself. I'll open an issue and offer to make a PR that makes it possible to run it more than once (or else split the size diffing based on some regex or something). |
|
It is odd that the bundle size changed for this PR though |
|
Opened this issue to allow discriminating against a custom comment key: preactjs/compressed-size-action#81 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I'm not sure if this is possible or necessary. It's trivial for team members to tell how much the bundle has actually changed (once you understand that you need to split the difference between the two build types). But it could be nice to have it split automatically anyway.
Additionally, I'm not sure if the compressed-size-action will allow two comments to be posted by it without over-writing each other. We'll see 🙂
Testing Instructions
Checklist
Update index.md).main) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin