Backport from WordPress Core: improve performance of WP_Theme_JSON::merge when merging background styles #66002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramonjd
added
[Type] Regression
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
1 similar comment
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ramonjd
added
[Status] In Progress
felixarntz
reviewed
Oct 10, 2024
ramonjd
force-pushed
the
backport/merge-theme-json-performance-6.7
branch
from
251e889
to
7c59449
Compare
ciampo
pushed a commit
that referenced
this pull request
Oct 14, 2024
…erge when merging background styles (#66002) Backporting the current state of WordPress/wordpress-develop#7486 and adding tests. Co-authored-by: ramonjd <[email protected]> Co-authored-by: mukeshpanchal27 <[email protected]> Co-authored-by: felixarntz <[email protected]> Co-authored-by: andrewserong < [email protected]> Co-authored-by: joemcgill < [email protected]>
ramonjd
added a commit
that referenced
this pull request
Nov 13, 2024
Including variations in the nodes array when 'include_node_paths_only' => true
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
…erge when merging background styles (WordPress#66002) Backporting the current state of WordPress/wordpress-develop#7486 and adding tests. Co-authored-by: ramonjd <[email protected]> Co-authored-by: mukeshpanchal27 <[email protected]> Co-authored-by: felixarntz <[email protected]> Co-authored-by: andrewserong < [email protected]> Co-authored-by: joemcgill < [email protected]>
ramonjd
added a commit
that referenced
this pull request
Nov 13, 2024
…_block_nodes (#66948) Follow up to #66002 Including variations in the nodes array when 'include_node_paths_only' => true Co-authored-by: ramonjd <[email protected]> Co-authored-by: aaronrobertshaw <[email protected]>
peterwilsoncc
pushed a commit
to peterwilsoncc/gutenberg-build
that referenced
this pull request
Nov 22, 2024
…_block_nodes (#66948) Follow up to WordPress/gutenberg#66002 Including variations in the nodes array when 'include_node_paths_only' => true Co-authored-by: ramonjd <[email protected]> Co-authored-by: aaronrobertshaw <[email protected]> Source: WordPress/gutenberg@d0a190b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Follow up to #64128
Backporting from WordPress/wordpress-develop#7486
See: https://core.trac.wordpress.org/ticket/61858
Props to @mukeshpanchal27 @felixarntz @joemcgill @andrewserong
Why?
The original implementation uses
WP_Theme_JSON::get_block_nodesto fetch the array of style node paths.WP_Theme_JSON::get_block_nodescalls WP_Theme_JSON::get_blocks_metadata`, which caused a significant performance regression. See: WordPress/performance#1572 (comment)Testing Instructions
See testing instructions in #64128
Also, run the tests!
npm run test:unit:php:base -- --filter WP_Theme_JSON_Gutenberg_Test