Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Update invalid JSON Schema link in README.md #69505

Merged

Conversation

Anuj-Rathore24
Copy link
Contributor

@Anuj-Rathore24 Anuj-Rathore24 commented Mar 10, 2025

what?

Closes #69504

This PR updates the broken JSON Schema link in README.md to point to the correct page listing editors that support JSON Schema.

why?

The existing JSON Schema link in README.md was broken and led to an unreachable page. This could confuse users who rely on the documentation to find supported editors. Updating the link ensures that users are directed to the correct resource.

how?

  • Replaced the incorrect JSON Schema link with the correct one, Json Schema

Screenshots or screencast

Before After
Screenshot 2025-03-10 at 12 47 29 PM Screenshot 2025-03-10 at 12 48 19 PM

Copy link

github-actions bot commented Mar 10, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Anuj-Rathore24 <[email protected]>
Co-authored-by: t-hamano <[email protected]>
Co-authored-by: shail-mehta <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @Anuj-Rathore24! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Mar 10, 2025
@t-hamano t-hamano added the [Type] Developer Documentation Documentation for developers label Mar 11, 2025
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Is https://json-schema.org/tools the correct URL?

@Anuj-Rathore24
Copy link
Contributor Author

hi @t-hamano, Thank you reviewing my PR🙇

Both URLs display the same content, with https://json-schema.org/tools being the main page and https://json-schema.org/implementations#editor just linking directly to the relevant section.

I can update the PR to use https://json-schema.org/tools if that’s preferred for consistency with the site's structure. Let me know how you'd like me to proceed!

@t-hamano
Copy link
Contributor

https://json-schema.org/implementations#editor just linking directly to the relevant section.

This link is redirected to the following link and the #editor seems to be deleted:

https://json-schema.org/tools?query=&sortBy=name&sortOrder=ascending&groupBy=toolingTypes&licenses=&languages=&drafts=&toolingTypes=&environments=&showObsolete=false

I feel https://json-schema.org/tools is the simplest and best.

@Anuj-Rathore24
Copy link
Contributor Author

Thanks for the clarification! 😊

I have updated my PR!!

@Anuj-Rathore24 Anuj-Rathore24 requested a review from t-hamano March 11, 2025 12:19
Copy link
Member

@shail-mehta shail-mehta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@shail-mehta shail-mehta added the props-bot Adding this label triggers the Props Bot workflow for a PR. label Mar 11, 2025
@github-actions github-actions bot removed the props-bot Adding this label triggers the Props Bot workflow for a PR. label Mar 11, 2025
@shail-mehta shail-mehta merged commit 9f77c96 into WordPress:trunk Mar 11, 2025
63 checks passed
@github-actions github-actions bot added this to the Gutenberg 20.5 milestone Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unreachable JSON Schema link in README for schema building
3 participants