-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Update invalid JSON Schema link in README.md #69505
Fix: Update invalid JSON Schema link in README.md #69505
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @Anuj-Rathore24! In case you missed it, we'd love to have you join us in our Slack community. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
Is https://json-schema.org/tools the correct URL?
hi @t-hamano, Thank you reviewing my PR🙇 Both URLs display the same content, with https://json-schema.org/tools being the main page and https://json-schema.org/implementations#editor just linking directly to the relevant section. I can update the PR to use https://json-schema.org/tools if that’s preferred for consistency with the site's structure. Let me know how you'd like me to proceed! |
This link is redirected to the following link and the I feel https://json-schema.org/tools is the simplest and best. |
Thanks for the clarification! 😊 I have updated my PR!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
what?
Closes #69504
This PR updates the broken JSON Schema link in README.md to point to the correct page listing editors that support JSON Schema.
why?
The existing JSON Schema link in README.md was broken and led to an unreachable page. This could confuse users who rely on the documentation to find supported editors. Updating the link ensures that users are directed to the correct resource.
how?
Screenshots or screencast