Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve consistency of sidebar controls for blocks within Navigation List view #68186

Open
getdave opened this issue Dec 20, 2024 · 1 comment
Labels
[Block] Navigation Link Affects the Navigation Link Block [Block] Navigation Affects the Navigation Block [Type] Enhancement A suggestion for improvement.

Comments

@getdave
Copy link
Contributor

getdave commented Dec 20, 2024

What problem does this address?

Any blocks within the Navigation block should offer the same controls for editing the Link Item text and URL.

Unfortunately whilst all Navigation Link block variations show these, other blocks sucvh as Button do not and it is only possible to edit via the canvas.

This provides a confusing UX.

Screen.Capture.on.2024-12-20.at.10-59-31.mp4

What is your proposed solution?

Show additional fields for Core's "allowed blocks" to ensure consistency of fields between all items in the editable lsit view.

@getdave getdave added [Block] Navigation Affects the Navigation Block [Block] Navigation Link Affects the Navigation Link Block [Type] Enhancement A suggestion for improvement. labels Dec 20, 2024
@Rishit30G
Copy link
Contributor

Hi @getdave, that's a great suggestion!
I was just looking into this issue, however I have few suggestions to make:
So for the UX part I do understand that it's a good point to have everything consistent 🙇🏻
But I somewhere feel it can be little over engineering to update every block to match their panels with Page Link's panel
And moreover all that the the extra fields are doing is helping in the navigation/accessibility related things like adding reltag and title and have nothing much to do on the UI front as far as I can see 👀
But yes, for the description there can be change on the UI if the theme supports it but I don't think that Buttons, Images or any other block would be needing that if inserted in the navigation block.

( I added all the fields in the page link panel for cart page )
Image

For example talking about the Button block, we can add the rel-tag from the Link rel Input from the 'Advance' section and for the button I don't think we need title and description as the button text is sufficient for Accessibility/SEO until and unless button text is ambiguous. Mostly these buttons will be Sign In, Sign Up, Contact Us or Get Started Buttons
And something similar can also be achieved for Image using the Alt tag

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Link Affects the Navigation Link Block [Block] Navigation Affects the Navigation Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

2 participants