Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure feature parity between Navigation Link and Navigation Submenu blocks. #68183

Open
getdave opened this issue Dec 20, 2024 · 0 comments
Open
Labels
[Block] Navigation Link Affects the Navigation Link Block [Block] Navigation Affects the Navigation Block [Block] Submenu Affects the Submenu Block - for submenus in navigation [Type] Enhancement A suggestion for improvement.

Comments

@getdave
Copy link
Contributor

getdave commented Dec 20, 2024

What problem does this address?

The core/navigation-link and core/navigation-submenu blocks are inconsistent with each other, despite the need for feature parity between them.

For example top level submenu items should have feature parity with top level link items.

However, as they do not share the same codebase a number of inconsistencies are in evidence which causes headaches for users, especially around styling. UI consistency would also help avoid confusion when editing menus.

What is your proposed solution?

Initially I propose we abstract and share key functionality between the blocks. We can do this by sharing code. Is their any precedent for this in the block-library?

In the longer term it might be possible to merge the blocks and remove the need for a separate submenu block.

@getdave getdave added [Block] Navigation Affects the Navigation Block [Block] Navigation Link Affects the Navigation Link Block [Block] Submenu Affects the Submenu Block - for submenus in navigation [Type] Enhancement A suggestion for improvement. labels Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Link Affects the Navigation Link Block [Block] Navigation Affects the Navigation Block [Block] Submenu Affects the Submenu Block - for submenus in navigation [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

1 participant