Simplify warning message in Navigation block settings. #68218
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @towfeeqkhan, @AvulaRamSwaroop. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
github-actions
bot
added
the
First-time Contributor
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @towfeeqkhan! In case you missed it, we'd love to have you join us in our Slack community. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
…issues for packages\block-library\src\navigation\edit\index.js" This reverts commit 3ff9b06.
|
Thanks for contributing, @towfeeqkhan! The PR contains a lot of unnecessary changes and fails Static Analysis checks. Please check the code contribution guidelines for how to fix them: https://developer.wordpress.org/block-editor/contributors/code/getting-started-with-code-contribution/#developer-tools. |
package.json
Outdated
| ], | ||
| "dependencies": { | ||
| "eslint": "8.3.0" | ||
| } |
There was a problem hiding this comment.
There should be no changes for this PR's package.json and package-lock.json files.
Please refer to the documentation for setting up code editor extensions.
package.json
Outdated
| @@ -99,6 +99,7 @@ | |||
| "equivalent-key-map": "0.2.2", | |||
| "esbuild": "0.18.20", | |||
| "escape-html": "1.0.3", | |||
| "eslint": "8.3.0", | |||
There was a problem hiding this comment.
This is the same problem. Changing a string doesn't require adding new project-wide dependencies.
The only change in this PR should be in the packages/block-library/src/navigation/edit/index.js file and for the submenuAccessibilityNotice as the issue suggests.
This pull request addresses a minor issue in the submenu warning text to enhance its readability and clarity. Fixes #68181