-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zoom out mode conflicts Write/Design mode #65901
Comments
I think we should somehow not allow - yet - switching modes. 😄 as in if modes are engaged the view is exited. |
Or exit zoom out when mode is changed? |
Noting the proposal to better combine these different options: #65736 |
The naming and workings of these modes are a little confusing. Select and edit mode have been renamed in the UI but the code implementation still refers to their original names:
On top of that, the ToolSelector uses a condition that only takes into consideragion However, what the Tool Selector should indicate as selected mode when Zoom Out is enabled? To me, Zoom Out is conceptually and technically an actual 'mode' and should be treated as such. In #65856 I'm proposing to expand the concept of 'modes' in the editor and make them more prominent. Also, by moving Zoom Out mode to the ToolSelector, the UI would present them as a single choice UI thus avoiding any confusion. |
I don't see a way forward here until we're aligned on whether or not we want to expose "Zoom Out" as a "mode". We have two viewpoints:
I would put this under "Needs Decision". |
Does this mean that zoom out mode will be removed from WordPress 6.7? |
No. Zoom Out as a feature will remain in 6.7. More discussion #65856. We should probably continue there to avoid splintering the discussion. |
Since the Write/Design modes are not included in WordPress 6.7, I am going to remove this issue from the 6.7 project board. If anyone objects, feel free to comment here and add back. |
@ndiego I think this should be for 6.7? It fixes a bug where one is in a mixed zoom out navigation mode state. |
Thanks for the clarification @draganescu, I added it back. |
Description
When the zoom out mode is enabled, what I should expect is the following:
However, switching modes from the Tools menu while the zoom out mode is active will result in unintended behavior.
Step-by-step reproduction instructions
Screenshots, screen recording, code snippet
e7846d9fae901fd2b09d1ced6f760045.mp4
Environment info
No response
Please confirm that you have searched existing issues in the repo.
Please confirm that you have tested with all plugins deactivated except Gutenberg.
The text was updated successfully, but these errors were encountered: