Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zoom Out Mode: Vertical Displacement: Safari issues #65125

Open
scruffian opened this issue Sep 6, 2024 · 1 comment
Open

Zoom Out Mode: Vertical Displacement: Safari issues #65125

scruffian opened this issue Sep 6, 2024 · 1 comment
Labels
Browser Issues Issues or PRs that are related to browser specific problems [Feature] Zoom Out [Type] Bug An existing feature does not function as intended

Comments

@scruffian
Copy link
Contributor

What problem does this address?

In #63896 we added a vertical displacement animation to zoom out mode, when dragging and dropping patterns between sections. In Safari these animations are a bit jerky and not as performant as other browsers.

@getdave summaried the issue as follows:

In relation to the jankyness of the separator animation in Safari. This is because the relatedTarget is not set when the dragleave event fires when leaving a block and entering the separator (caused by the animation).

The info on the draglave targets is as follows:

target - The EventTarget the pointing device exited from
relatedTarget - The EventTarget the pointing device entered to
As the relatedTarget is null we cannot detect that the drag has started over a separator (like we can in Chrome) an thus we cannot cancel the dragLeave handler on useBlockDropZone. This means that the hideInsertionPoint action is dispatched which causes the flicker.

The bug in Safari is - https://bugs.webkit.org/show_bug.cgi?id=66547

What is your proposed solution?

Unsure!

@scruffian scruffian added the [Type] Enhancement A suggestion for improvement. label Sep 6, 2024
@scruffian scruffian added [Type] Bug An existing feature does not function as intended [Feature] Zoom Out and removed [Type] Enhancement A suggestion for improvement. labels Sep 6, 2024
@getdave getdave self-assigned this Sep 6, 2024
@mtias mtias added the Browser Issues Issues or PRs that are related to browser specific problems label Sep 7, 2024
@andrewserong
Copy link
Contributor

Thanks for opening up a follow-up issue to track this!

@getdave getdave removed their assignment Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Browser Issues Issues or PRs that are related to browser specific problems [Feature] Zoom Out [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

4 participants