Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overrides shouldn't be applicable to unsynced patterns #61610

Closed
jameskoster opened this issue May 13, 2024 · 1 comment · Fixed by #61639
Closed

Overrides shouldn't be applicable to unsynced patterns #61610

jameskoster opened this issue May 13, 2024 · 1 comment · Fixed by #61639
Assignees
@kevin940726
Labels
[Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced Needs Dev Ready for, and needs developer efforts [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@jameskoster
Copy link
Contributor

Currently it's possible to 'Enable overrides' when editing an unsynced pattern in focus mode. This doesn't really make sense, given all block properties in an unsynced pattern are editable post insertion. Nothing is synced, so there's nothing to override.
@jameskoster jameskoster added [Type] Bug An existing feature does not function as intended [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced labels May 13, 2024
@jameskoster jameskoster moved this to Needs Dev in Design priorities May 13, 2024
@jameskoster jameskoster added the Needs Dev Ready for, and needs developer efforts label May 13, 2024
@talldan talldan mentioned this issue May 14, 2024
Closed
22 tasks
@talldan
Copy link
Contributor

talldan commented May 14, 2024

Thanks for catching that, I've added this to the iteration issue - #59819

@kevin940726 kevin940726 mentioned this issue May 14, 2024
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label May 14, 2024
@github-project-automation github-project-automation bot moved this from Needs Dev to Done in Design priorities May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevin940726 kevin940726

Labels
[Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced Needs Dev Ready for, and needs developer efforts [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
Design priorities
Status: Done
WordPress 6.6 Editor Tasks
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix blocks in unsynced patterns can enable overrides WordPress/gutenberg
3 participants
@talldan @jameskoster @kevin940726