Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try using synced color on the block icon for overrides #61515

Closed
richtabor opened this issue May 9, 2024 · 3 comments · Fixed by #61560
Closed

Try using synced color on the block icon for overrides #61515

richtabor opened this issue May 9, 2024 · 3 comments · Fixed by #61560
Assignees
Labels
[Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@richtabor
Copy link
Member

richtabor commented May 9, 2024

Instead of using the "connected" icon to indicate a synced pattern, in place of the block icon, let's try using the synced color applied to the block icon instead. Maintaining the block icon is helpful for understanding block selection when using list view or content only view. And this reduces adding a new icon/concept to comprehend.

Iteration: #59819

Visual

CleanShot 2024-05-09 at 14 54 09

CleanShot 2024-05-09 at 16 02 47

@richtabor richtabor added [Type] Enhancement A suggestion for improvement. [Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) labels May 9, 2024
@kevin940726 kevin940726 self-assigned this May 9, 2024
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label May 10, 2024
@annezazu
Copy link
Contributor

I like this conceptually and am keen to try it out. My biggest question mark is around how we are creating a new mental model when you think about block connections. In this case, folks will see the connected icon and the block icon in different parts of the editing experience rather than just one unified option (connected icon). I also worry a bit that we're conflating mental models in that typically when items are purple, like a synced pattern or template part, that's because we're (trying) to communicate that it will be updated everywhere. In this case, we're saying the opposite: this block can be edited because of overrides and will be custom just to this instance of the pattern.

@annezazu
Copy link
Contributor

Found this a11y issue related to the connections icon. Let's avoid the same problem: #60810

@richtabor
Copy link
Member Author

For reference, here's the current: CleanShot 2024-05-31 at 10 30 52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants