-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A consistent aspect ratio component #47962
Comments
In #47271 the settings are saved in theme.json |
This would also be addressed by eliminating one-off blocks like this. See: |
@scruffian The idea here is that the aspect ratios will be part of Global Styles and referenced throughout related controls. This PR (#47271) was the start of that, but we held off for 6.2. Is this what you're referring to? |
At the moment we have some settings in Global Styles and some in the Post Featured Image block. They are the same, but they are separate lists - so if we change one there's a risk we forget to change the other and they'll become out of sync. We should update this so that there is only one list to remove that risk. |
Following up on this one, now that the Cover block has an aspect ratio control, it'd be good to bring that to Featured Image and Image as well, since it's the correct 40px size. See also #58230 |
What problem does this address?
We have two copies of the image aspect ratios (one in Global Styles (and the Image block), and the other in the Featured Image block #47854).
What is your proposed solution?
We should find a way to share this code, potentially moving the width/height/scale/aspect ratios to components. These experiences should be consistent across the board, as well as future implementations (like the Cover block #54032).
This is blocked by #55059, which allows for the Image block to utilize units for image sizes. When that's complete, these controls can be 1:1 across both (and future) areas.
Other ideas
The text was updated successfully, but these errors were encountered: