-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add categories to the "New Page" pattern modal #46498
Comments
Tagging in @WordPress/gutenberg-design on this one too :) |
Proposed solution of using existing "Explore all" sounds good. I think there's still an opportunity for further unification at a later time. We have a couple of very adjacent modals:
All of those could be considered as part of a whole, and look and behave similarly. |
Re unification, I just wanted to point to issue #39308 which has some designs for that. They probably need some polishing, but I'm sharing here in case we want to implement any of those ideas. |
There is a PR here which addresses the modal size and is associated to this issue: |
@jameskoster @jasmussen I was looking at new page modal and while it looks great, it still feels like category-list would be very helpful for sites with lots of patterns? |
I'm wondering whether this modal could be updated to utilise the data view work and make use of all the associated features (search/filtering, view options, pagination, etc). That would allow users to filter by category, and anything else deemed useful. |
@scruffian I think this can be closed now that #66836 merged? |
What problem does this address?
As implemented previously, when registering patterns with
'blockTypes' => array( 'core/post-content' )
annotation, they appear in a modal when creating a new page:The small modal becomes unwieldly very quickly when a theme or plugin registers dozens of patterns:
Screen.Recording.2022-12-13.at.12.50.08.mov
What is your proposed solution?
Basically re-use already existing "Explore all patterns" modal. That seemed to be intention in the original issue as well.
Categories could be pulled from existing
categories
key, without needing to introduce new APIs.The text was updated successfully, but these errors were encountered: