Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the unwrap transform some container blocks have #45841

Closed
dsas opened this issue Nov 17, 2022 · 3 comments
Closed

Move the unwrap transform some container blocks have #45841

dsas opened this issue Nov 17, 2022 · 3 comments
Labels
[Block] Columns Affects the Columns Block [Block] Group Affects the Group Block (and row, stack and grid variants) [Block] Quote Affects the Quote Block Needs Dev Ready for, and needs developer efforts [Type] Enhancement A suggestion for improvement.

Comments

@dsas
Copy link
Contributor

dsas commented Nov 17, 2022

What problem does this address?

Columns, quotes and groups all have an 'unwrap' transform which removes the block, replacing it with the contained content. Unwrap isn't really a transform in the sense that the other transforms are and is perhaps a bit unclear. Unwrap is closer to ungroup which lives in the ellipses menu.

See #45666 (comment) for initial discussion of this confusion

What is your proposed solution?

Add "Ungroup" to every container ellipsis menu, in the same position as Ungroup (maybe call it Unwrap or otherwise for non-group blocks) — and consider giving it a shortcut such as ⌘⇧G

@bph bph added [Type] Enhancement A suggestion for improvement. [Block] Columns Affects the Columns Block [Block] Quote Affects the Quote Block [Block] Group Affects the Group Block (and row, stack and grid variants) Needs Technical Feedback Needs testing from a developer perspective. labels Nov 17, 2022
@talldan talldan added Needs Design Feedback Needs general design feedback. and removed Needs Technical Feedback Needs testing from a developer perspective. labels Apr 11, 2023
@talldan
Copy link
Contributor

talldan commented Apr 11, 2023

It sounds like the issue is calling for changes in the UI, so I've changed the label to 'Needs Design Feedback'.

There doesn't seem to be anything challenging in the technical implementation, so removing 'Needs Technical Feedback'.

@jasmussen
Copy link
Contributor

I agree with this quite a lot. Unwrap feels both like the wrong term, and its placement as a transform destination feels wrong. So I would echo this:

  • Remove the "Unwrap" from the transform menu, rename the feature to "Ungroup". It can still unwrap a columns block or any other container with that term, since those are also just groups of content.
  • Have generic shortcuts for both, ⌘G to convert it to Group, but ⌘⇧G to ungroup (e.g. also for a Columns block)

@richtabor
Copy link
Member

Upwrap has been removed; closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Columns Affects the Columns Block [Block] Group Affects the Group Block (and row, stack and grid variants) [Block] Quote Affects the Quote Block Needs Dev Ready for, and needs developer efforts [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

5 participants