-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugin: Backport PHP changes for WordPress 6.1 release #43440
Comments
I'll create a patch for changes in The @ntsekouras, correct me if I'm wrong, but the |
Heads-up that I opened a PR in wordpress-develop: WordPress/wordpress-develop#3131 which implements the same fix as #43597 in Related track issue: https://core.trac.wordpress.org/ticket/55881#ticket |
Good catch @Mamaduka ! It seems so. |
I can take care of all the spacing size preset related changes. |
@ockham, @michalczaplinski, do we have a core tracking ticket to reference in Core PRs? |
@Mamaduka Ah, we didn't -- my apologies! I've filed one now: https://core.trac.wordpress.org/ticket/56467 |
I'm happy to help out with Layout backports. I'm travelling at the moment but can start looking at some of them next week when I'm back. Some of them might have a couple of challenges — layout.php currently depends on the style engine work in the style engine package (so just CCing @ramonjd there), which might need to land first? Also, I was wondering how we deal with PHP changes that require JS changes to be shipped at the same time? I think some of the Layout work might need to happen all at once 🤔. There's definitely pieces that can be done in separate PRs first, though, so I'll give it a bit more thought to see what sort of order might work. Just linking a couple of other pre-requisites for Layout in Gutenberg being merged to core:
I believe the above two tickets/PRs will need to land prior to the |
My backport PRs are ready:
The #40416 should already be in Core, cherry-picked for a minor release - WordPress/wordpress-develop#2600. I've only done a minor code quality work for |
Small update: In WordPress/wordpress-develop#3154, I'm attempting a package sync to update Core to the latest package versions -- mostly as a dry-run for Beta 1. (I would like to actually merge it once its ready -- see its PR desc for context). In order to unblock that PR, I've filed a small backport PR to add the |
In addition to that, we need to refactor all occurrences of |
Good point. Here's one approach for |
I'm working on prepping packages/style-engine for inclusion in core. WIP here: WordPress/wordpress-develop#3199 This will unblock most of the lib/block-supports migrations given that they're using style engine methods. It requires https://core.trac.wordpress.org/ticket/55966, otherwise I'll need to migrate gutenberg_safecss_filter_attr_allow_css_6_1 to core to make the Style Engine work. 😱 |
I've asked in #core for someone to merge 55966's patch 🙂 |
As the Feature Freeze is only two weeks away, I'll start pinging some folks who I know have good domain knowledge of certain areas and can help backporting some files 😊 @ntsekouras -- Could you file a backport PR for the changes you made to |
@jorgefilipecosta -- Could you maybe file a backport PR for #41791 (affecting block-patterns.php, class-gutenberg-rest-block-patterns-controller.php, and rest-api.php)? 🙏 |
Sure 👍 |
@oandregal -- Could you maybe file a backport PR for #25892 (Quote v2)? 🙏 |
I'm taking a look at persisted preferences. |
Backport PR for #42729 is ready for testing - WordPress/wordpress-develop#3234. |
Prepared WordPress/wordpress-develop#3247 to backport some recent changes: #44015 #44109 and #44159 |
Thanks for all the help landing part 1 of the Layout refactor! Update on Layout and Spacing presets follow-up backports:
|
Prepared WordPress/wordpress-develop#3261 to backport #44189 (which is approved but I'm waiting for the tests to pass and will backport to 14.1). |
Just looking over the theme JSON file and saw that |
Block supports scripts loadingAdded WordPress/wordpress-develop#3273 as an extension of WordPress/wordpress-develop#3259 cc @ockham |
…om Gutenberg to WP 6.1. This changeset backports `border`, `color`, `elements` and `spacing` block supports changes from Gutenberg to WP 6.1. See tracking issue on Gutenberg repository: [WordPress/gutenberg#43440 gutenberg#43440]. Props ramonopoly, glendaviesnz, bernhard-reiter, audrasjb, costdev. See #56467. git-svn-id: https://develop.svn.wordpress.org/trunk@54211 602fd350-edb4-49c9-b593-d223f7449a82
…om Gutenberg to WP 6.1. This changeset backports `border`, `color`, `elements` and `spacing` block supports changes from Gutenberg to WP 6.1. See tracking issue on Gutenberg repository: [WordPress/gutenberg#43440 gutenberg#43440]. Props ramonopoly, glendaviesnz, bernhard-reiter, audrasjb, costdev. See #56467. Built from https://develop.svn.wordpress.org/trunk@54211 git-svn-id: http://core.svn.wordpress.org/trunk@53770 1a063a9b-81f0-0310-95a4-ce76da25c4cd
…om Gutenberg to WP 6.1. This changeset backports `border`, `color`, `elements` and `spacing` block supports changes from Gutenberg to WP 6.1. See tracking issue on Gutenberg repository: [WordPress/gutenberg#43440 gutenberg#43440]. Props ramonopoly, glendaviesnz, bernhard-reiter, audrasjb, costdev. See #56467. Built from https://develop.svn.wordpress.org/trunk@54211 git-svn-id: https://core.svn.wordpress.org/trunk@53770 1a063a9b-81f0-0310-95a4-ce76da25c4cd
I've prepared WordPress/wordpress-develop#3313 to backport the changes at #44363 |
I can confirm that all the changes are present in WordPress core.
We didn't include this new API in WP core in 6.1. PR that reflects that in the plugin is ready for review: #44414. |
I think this one is missing from some of the backports above: WordPress/wordpress-develop#3319 |
I removed all of the Webfonts API files from the backport list. Why? The API is being re-architected, ie still in development. It will not be ready for WP 6.1. 🔴 Please leave these files in the |
Now that the 6.1 release is out, I think we can close this issue. |
…om Gutenberg to WP 6.1. This changeset backports `border`, `color`, `elements` and `spacing` block supports changes from Gutenberg to WP 6.1. See tracking issue on Gutenberg repository: [WordPress/gutenberg#43440 gutenberg#43440]. Props ramonopoly, glendaviesnz, bernhard-reiter, audrasjb, costdev. See #56467. git-svn-id: https://develop.svn.wordpress.org/trunk@54211 602fd350-edb4-49c9-b593-d223f7449a82
Description
Related Trac ticket 56467.
This is the tracking issue to coordinate the process of backporting all PHP changes added in the Gutenberg plugin that needs to be backported for the WordPress 6.1 release.
Files listed for WP 6.1
lib/block-supports
Backporting block supports [border, color, elements, spacing] from Gutenberg to WP 6.1 wordpress-develop#3204 🟢border.php
Backporting block supports [border, color, elements, spacing] from Gutenberg to WP 6.1 wordpress-develop#3204 🟢colors.php
No changes since WP 6.0.dimensions.php
Backport duotone block supports for WP 6.1 wordpress-develop#3210 🟢duotone.php
Backporting block supports [border, color, elements, spacing] from Gutenberg to WP 6.1 wordpress-develop#3204 🟢elements.php
@andrewserong (ref). Blocked by safecss_filter_attr: Add exceptions for min(), max(), etc. functions wordpress-develop#3212 and Add layout-related CSS properties to safe_style_css_filter in kses.php wordpress-develop#2928. Style engine: migrate functions, classes and tests wordpress-develop#3199 Backport Layout block support refactor part 2 wordpress-develop#3254 🟢layout.php
Backporting block supports [border, color, elements, spacing] from Gutenberg to WP 6.1 wordpress-develop#3204 🟢spacing.php
Backport typography block supports for WP 6.1 wordpress-develop#3203 🟢typography.php
No changes since WP 6.0.utils.php
lib/compat/wordpress-6.1
- Layout: #42906 Spacing: #42173 🟢block-editor-settings.php
block-patterns.php
- 🔴 Patterns registered in this file are not in Core.Site editor: #3214 🟢block-template-utils.php
blocks.php
🔴 It seems that the multipleviewScripts
feature has not been backported.No changes since WP 6.0.class-gutenberg-rest-block-patterns-controller.php
No changes since WP 6.0.class-gutenberg-rest-templates-controller.php
Elements API updates backport wordpress-develop#3206 Backport foundation for Layout block support refactor (part 1) wordpress-develop#3205 Backport spacing presets wordpress-develop#3255 🟢class-wp-theme-json-6-1.php
Backport spacing presets wordpress-develop#3255class-wp-theme-json-resolver-6-1.php
Code is already in Core 🟢date-settings.php
Preload settings and templates permissions for post editor wordpress-develop#3156 @Mamaduka 🟢edit-form-blocks.php
🟢get-global-styles-and-settings.php
Backport block editor persisted preferences wordpress-develop#3219 🟢persisted-preferences.php
🟢rest-api.php
Style engine changes in WordPress/wordpress-develop#3218 🟢script-loader.php
theme-i18n.json
🔴Backport foundation for Layout block support refactor (part 1) wordpress-develop#3205 🟢theme.json
@andrewserong Should be covered by layout related work. Only affected by Layout: Add a disable-layout-styles theme supports flag to opt out of all layout styles #42544. 🟢theme.php
(No need to backport, see Plugin: Backport PHP changes for WordPress 6.1 release #43440 (comment).)wp-theme-get-post-templates.php
lib/experimental
No need to backport: Only used for mobile editor. @geriux confirmed that the endpoint is only available from the GB plugin for now.block-editor-settings-mobile.php
Deleted.blocks.php
class-wp-rest-block-editor-settings-controller.php
class-wp-rest-customizer-nonces.php
No need to backport -- "alias" wrapper aroundclass-wp-theme-json-gutenberg.php
WP_Theme_JSON_6_1
.class-wp-theme-json-resolver-gutenberg.php
[ ]🔴 Webfonts API is still in development and not ready for WP 6.1.class-wp-webfonts-provider-local.php
[ ]🔴 Webfonts API is still in development and not ready for WP 6.1.class-wp-webfonts-provider.php
[ ]🔴 Webfonts API is still in development and not ready for WP 6.1.class-wp-webfonts.php
editor-settings.php
navigation-page.php
navigation-theme-opt-in.php
[ ]🔴 Webfonts API is still in development and not ready for WP 6.1.register-webfonts-from-theme-json.php
rest-api.php
[ ]🔴 Webfonts API is still in development and not ready for WP 6.1.webfonts.php
Legend:
🟢 – confirmed for WP 6.1
🟡 – needs decision
🔴 – moved to future WP release
Getting Involved
If you are interested in helping with the effort, can you comment (or edit the issue's description) with your name next to the file if you plan to help with backporting. It would also help to link to Track issues / GitHub PRs in WordPress core when they are available.
Action items when working on backports:
wp_
prefix instead ofgutenberg_
and guard with declaration checks for code that needs to be backported to WordPress core.@since 6.1.0
documentation tag included.Note that @hellofromtonya has started work to smoothen the backporting process, by adjusting Gutenberg's test and lint structure to more closely resemble Core's (to avoid having to fix code in backport PRs when they don't pass
wordpress-develop
's tests even though they did pass Gutenberg's): #43333Issue modeled after #39889.
The text was updated successfully, but these errors were encountered: