Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query Loop Block: Cannot choose grid pattern #41297

Closed
KokkieH opened this issue May 25, 2022 · 5 comments
Closed

Query Loop Block: Cannot choose grid pattern #41297

KokkieH opened this issue May 25, 2022 · 5 comments
Labels
[Block] Query Loop Affects the Query Loop Block Needs Design Needs design efforts.

Comments

@KokkieH
Copy link

KokkieH commented May 25, 2022

Description

When inserting a query loop block there's a prompt to choose a pattern for the block. The subsequent modal has icons for list and grid views at the bottom, but if you click the grid icon, the Choose button disappears so the pattern cannot be selected.

Step-by-step reproduction instructions

  1. Create a new page or page template
  2. Insert the Query Loop block
  3. Click Choose to select a pattern
  4. Click the Grid icon at the bottom of the modal
  5. Note that the "Choose" button that was visible on the List view, disappears when switching to Grid view

Screenshots, screen recording, code snippet

Editor__beta__‹My_Core_Sandbox—_WordPress

Editor__beta__‹My_Core_Sandbox—_WordPress

Environment info

  • WordPress 6.0, Twenty Twenty-Two v1.2
  • Can replicate with and without Gutenberg v13.2.2 activated
  • Firefox 100.0.2 on MacOS 12.3.1
  • Reported by a WordPress.com user with Chrome 101 on Windows 10

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@Mamaduka Mamaduka added the [Block] Query Loop Affects the Query Loop Block label May 25, 2022
@Mamaduka
Copy link
Member

Mamaduka commented May 25, 2022

Hello, @KokkieH

Clicking on the pattern in the grid view will select it.

I think we should make this action clear. Cc @jameskoster.

@Mamaduka Mamaduka added the Needs Design Needs design efforts. label May 25, 2022
@KokkieH
Copy link
Author

KokkieH commented May 25, 2022

Ah, now I get it, @Mamaduka. It's not list-patterns and grid-patterns, but a list-view and grid-view of the available patterns. The user who reported this on WordPress.com and I both got this wrong, so yeah, it would be good if that could be a bit more clear :D

@jameskoster
Copy link
Contributor

Thanks for the ticket (and mention)!

I shared some designs in #39308 which eliminate the "Choose" button altogether.

@priethor
Copy link
Contributor

@KokkieH thanks for reporting!

Do you mind if we close this issue and consolidate the work in #39308, as it will solve the problem?

@KokkieH
Copy link
Author

KokkieH commented May 27, 2022

@priethor that's absolutely fine, yes. Thank you :)

@KokkieH KokkieH closed this as completed May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Query Loop Affects the Query Loop Block Needs Design Needs design efforts.
Projects
None yet
Development

No branches or pull requests

4 participants