Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make pattern modal views more consistent #41033

Closed
richtabor opened this issue May 12, 2022 · 2 comments
Closed

Make pattern modal views more consistent #41033

richtabor opened this issue May 12, 2022 · 2 comments
Labels
[Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced

Comments

@richtabor
Copy link
Member

What problem does this address?

Now that we have a number of pattern experiences within core, we should consider where there are inconsistencies that can be brought closer together. I've outlined the three pattern modal experiences from a block selection (__experimentalBlockPatternSetup), add new page, and pattern explorer:

From the Query loop block's pattern selector:

CleanShot 2022-05-12 at 11 06 37@2x

From the new 6.0 core/post-content Add new modal:

( I just added two random patterns to the blockType, so we could see these here)
CleanShot 2022-05-12 at 11 04 48@2x

From the Pattern Explorer:

CleanShot 2022-05-12 at 11 05 02@2x

What is your proposed solution?

1. Remove single-view from __experimentalBlockPatternSetup

Take the block pattern selector (__experimentalBlockPatternSetup) and make it back to a grid view (not the current single pattern view). Consider even removing the single view entirely (not sure how helpful that is).

2. Make pattern modal UI consistent

Make the modal UI consistent across all three experiences (width, columns, modal headers, etc).

3. Possibly add another level of categorization for blockTypes

Consider adding a sub-categorization layer to blockTypes, which could be very similar to the current Pattern Explorer UI does (sidebar with search + category)). This would be particularly useful for the "Add new" pattern view, where I could select the type of page to add, instead of seeing an uncategorized list of page patterns.

This could also be interesting for the Query block's __experimentalBlockPatternSetup use case as well, where the query patterns could be categorized by column count, featured images, grid, etc. (If this is interesting, we should probably spin up another issue relative to this).

Thoughts? 🤔

@richtabor richtabor added the [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced label May 12, 2022
@annezazu
Copy link
Contributor

Thanks for opening this up @richtabor! At a glance, this seems wildly similar to this issue: #39308 Mind consolidating feedback there and perhaps closing this one out instead?

@richtabor
Copy link
Member Author

Good catch, will do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced
Projects
None yet
Development

No branches or pull requests

2 participants