Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template Part replacement modal – make results searchable #40791

Closed
jameskoster opened this issue May 3, 2022 · 9 comments · Fixed by #42459
Closed

Template Part replacement modal – make results searchable #40791

jameskoster opened this issue May 3, 2022 · 9 comments · Fixed by #42459
Assignees
Labels
[Block] Template Part Affects the Template Parts Block Needs Design Feedback Needs general design feedback.

Comments

@jameskoster
Copy link
Contributor

When there are many options in the replace modal it can be difficult to find a specific template part you have in mind. This is already an issue in Twenty Twenty-Two:

replace.mp4

Making the list searchable can help ease this pain point.

searchable-modal.mp4
@jameskoster jameskoster added Needs Design Feedback Needs general design feedback. [Block] Template Part Affects the Template Parts Block labels May 3, 2022
@shaunandrews
Copy link
Contributor

If you know the name of the template part, this might help. It would be nice to only show the search input if there are more than a few template parts.

Maybe, instead of a search box there were display options to show template parts in different views. For example, instead of just a stacked display of large previews you could switch to a grid of thumbnails, or a simple list with a focus on the label.

@jameskoster
Copy link
Contributor Author

Good points. The display options are posed in #39308, but still need some design exploration.

@Mamaduka
Copy link
Member

Mamaduka commented Jul 7, 2022

@jameskoster, is anyone working on this issue?

@jameskoster
Copy link
Contributor Author

jameskoster commented Jul 7, 2022

@Mamaduka not that I am aware of. If you're thinking about picking it up, it may be worth taking a look at #39308 first (#39308 (comment) specifically), for an idea of the overall direction for these pattern modals. Just in case that informs any implementation details here :)

@Mamaduka
Copy link
Member

Mamaduka commented Jul 7, 2022

Thanks, I will do.

@Mamaduka
Copy link
Member

@jameskoster, I was wondering if moving template part replacements into Block actions dropdown would make this modal obsolete.

P.S. Do we have mockups of how replacements should look in the block actions dropdown - #40208 (comment)?

@jameskoster
Copy link
Contributor Author

Because we can't account for the appearance or quantity of headers I still think the modal makes sense.

Perhaps something like this could work:

Screenshot 2022-07-13 at 12 09 24

@Mamaduka
Copy link
Member

@jameskoster, do we want to hide SearchComponent if there're fewer than X items (#42337)?

@jameskoster
Copy link
Contributor Author

Good question. I don't know if it's so important to hide the search component here... if the previews happen to be very tall, you may still want to search to avoid scrolling, even if there are only a few options.

@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jul 15, 2022
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Template Part Affects the Template Parts Block Needs Design Feedback Needs general design feedback.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants