Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding additional templates types (author, date, taxonomy, etc) flashes default template content #40286

Closed
annezazu opened this issue Apr 12, 2022 · 3 comments · Fixed by #40841
Closed

Adding additional templates types (author, date, taxonomy, etc) flashes default template content #40286

annezazu opened this issue Apr 12, 2022 · 3 comments · Fixed by #40841
Assignees
@Mamaduka
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Feature] Template Editing Mode Related to the template editor available in the Block Editor [Type] Bug An existing feature does not function as intended

Comments

@annezazu
Copy link
Contributor

Description

When adding new template types thanks to this PR #39353, the content of the default template flashes before showing a blank template.

Step-by-step reproduction instructions

  1. Open the Site Editor.
  2. Go to the Template List.
  3. Click "Add" and select one of the new template types (date, taxonomy, author, etc).
  4. Notice the problem.

Screenshots, screen recording, code snippet

flashing.templates.mov

Environment info

  • WordPress 6.0 Beta 1.
  • TT2.

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes
@annezazu annezazu added [Type] Bug An existing feature does not function as intended [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Feature] Template Editing Mode Related to the template editor available in the Block Editor labels Apr 12, 2022
@annezazu
Copy link
Contributor Author

This was replicated by a participant in the thirteen call for testing for the FSE Outreach Program:

I saw the blip of the other template as well on first load.

@annezazu
Copy link
Contributor Author

cc @scruffian since it seems you worked on implementing the additional template types in case you can help move this forward: #39353

@ndiego ndiego moved this from Triage to Todo in WordPress 6.0 Editor Tasks Apr 29, 2022
@Mamaduka Mamaduka mentioned this issue May 5, 2022
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label May 5, 2022
@Mamaduka
Copy link
Member

Mamaduka commented May 5, 2022

Create PR to fix this issue - #40841.

@Mamaduka Mamaduka moved this from Todo to In Progress in WordPress 6.0 Editor Tasks May 5, 2022
Repository owner moved this from In Progress to Done in WordPress 6.0 Editor Tasks May 6, 2022
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mamaduka Mamaduka

Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Feature] Template Editing Mode Related to the template editor available in the Block Editor [Type] Bug An existing feature does not function as intended
Projects
No open projects
WordPress 6.0 Editor Tasks
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Site Editor: Avoid previous content flash when a new template is created WordPress/gutenberg
3 participants
@Mamaduka @annezazu @priethor